Skip to content

Conversation

m4rch3n1ng
Copy link
Contributor

running cargo +beta check on this crate currently generates this warning:

warning: hiding a lifetime that's elided elsewhere is confusing
   --> src/control/property.rs:131:26
    |
131 |     pub fn convert_value(&self, value: RawValue) -> Value {
    |                          ^^^^^                      ----- the same lifetime is hidden here
    |                          |
    |                          the lifetime is elided here
    |
    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: use `'_` for type paths
    |
131 |     pub fn convert_value(&self, value: RawValue) -> Value<'_> {
    |                                                          ++++

warning: `drm` (lib) generated 1 warning

this pr fixes that to preempt future ci failures on the next stable rust bump in ~2w.

(note: technically cargo +beta check has slightly different wording, but the wording was changed and is being backported to beta before the next release)

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@Drakulix Drakulix merged commit f383da8 into Smithay:develop Jul 25, 2025
16 checks passed
@m4rch3n1ng m4rch3n1ng deleted the fix-mismatched-lifetime-syntaxes branch July 25, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants