PropertyBaseEffect #8256
Draft
PropertyBaseEffect #8256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
|
This will remain in draft until properties are officially fully released and ready to go. |
sovdeeth
requested changes
Oct 26, 2025
| "unload all worlds" | ||
| }) | ||
| @Description(""" | ||
| Load or unload a world. |
There was a problem hiding this comment.
mention the unload world property here since we don't have 'see also'
Comment on lines
+45
to
+47
| "[the] [current] script [file]", | ||
| "[the] script[s] [file[s]] [named] %strings%", | ||
| "[the] skript file[s] %strings%", |
There was a problem hiding this comment.
skript file is a lot more than a script
Suggested change
| "[the] [current] script [file]", | |
| "[the] script[s] [file[s]] [named] %strings%", | |
| "[the] skript file[s] %strings%", | |
| "[the] [current] script [file]", | |
| "[the] script[s] [file[s]] [named] %strings%", |
Comment on lines
+149
to
+168
| public void execute(Script script, OpenCloseable closeable) { | ||
| File file = script.getConfig().getFile(); | ||
| if (file == null || !file.exists()) | ||
| return; | ||
| if (ScriptLoader.getLoadedScripts().contains(ScriptLoader.getScript(file))) | ||
| return; | ||
| if (ScriptLoader.getDisabledScriptsFilter().accept(file)) { | ||
| try { | ||
| file = FileUtils.move( | ||
| file, | ||
| new File(file.getParentFile(), file.getName().substring(ScriptLoader.DISABLED_SCRIPT_PREFIX_LENGTH)), | ||
| false | ||
| ); | ||
| } catch (IOException e) { | ||
| Skript.exception("Error while enabling script file: " + script.name()); | ||
| return; | ||
| } | ||
| } | ||
| ScriptLoader.loadScripts(file, closeable); | ||
| } |
There was a problem hiding this comment.
this seems like somethign that should be on Script rather than here
Comment on lines
+179
to
+187
| public void execute(Script script, OpenCloseable closeable) { | ||
| File file = script.getConfig().getFile(); | ||
| if (file == null || !file.exists()) | ||
| return; | ||
| if (ScriptLoader.getDisabledScriptsFilter().accept(file)) | ||
| return; | ||
| unloadScripts(file); | ||
| ScriptLoader.loadScripts(file, closeable); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current property system does not yet have support for common effect syntaxes and no common property handler used for effects.
Solution
Adds PropertyBaseEffect, class for using common effects with only 1 input in the syntax.
Adds EffectHandler, common handler used in PropertyBaseEffect
Adds effects and properties for: load, unload, reload, enable, and disable.
ScriptClassInfo includes all of these properties
Moves classinfo for World into it's own class, WorldClassInfo, with an unload property.
Refactors EffScriptFile to enable/load/reload a script with errors to be printed, removes some patterns that are now in ExprScript, and moved into org.
Refactors EffWorldLoad with the only unload option to be without saving
Testing Completed
quickTest
Supporting Information
N/A
Note
PR currently fails due to pattern conflicts because of property syntaxes and their original classes.
Completes: none
Related: none