Ensure that unload event is called before unloading of functions regardless of order in script. #8250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TFSMads
requested review from
APickledWalrus and
Absolutionism
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
APickledWalrus
requested changes
Oct 22, 2025
sovdeeth
approved these changes
Oct 23, 2025
skriptlang-automation
bot
removed
the
needs reviews
sovdeeth
added
the
bug
1 task
Efnilite
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
functions appearing before on unload event is unloaded before event is called.
Solution
When unloading a script unload event is moved to front of list so that it is triggered before unloading of functions.
Testing Completed
I have tested it on version 1.21.10.
Supporting Information
Completes: #8233
Related: none