Fixed block name set from variable not working #8249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriptlang-automation
bot
added
the
needs reviews
erenkarakal
requested changes
Oct 22, 2025
Co-authored-by: Eren <67760502+erenkarakal@users.noreply.github.com>
Co-authored-by: Eren <67760502+erenkarakal@users.noreply.github.com>
Absolutionism
requested changes
Oct 22, 2025
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Absolutionism
approved these changes
Oct 22, 2025
sovdeeth
requested changes
Oct 22, 2025
skriptlang-automation
bot
removed
the
needs reviews
sovdeeth
approved these changes
Oct 23, 2025
skriptlang-automation
bot
added
the
patch-ready
sovdeeth
added
the
bug
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When setting a chest from a variable where the chest name is set, it won't apply to the actual chest.
Solution
I have added copying of name from itemmeta to the container in ItemType#copyContainerState.
Testing Completed
I have written a test script that i have run successfully on versions: 1.20.6, 1.21.3 , 1.21.4, 1.21.5, 1.21.8 and 1.21.10
Supporting Information
Completes: #8246
Related: none