-
-
Notifications
You must be signed in to change notification settings - Fork 414
Copper Golem + Copper Block Support #8244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Absolutionism
wants to merge
10
commits into
SkriptLang:dev/feature
Choose a base branch
from
Absolutionism:dev/CopperGolem
base: dev/feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Copper Golem + Copper Block Support #8244
Absolutionism
wants to merge
10
commits into
SkriptLang:dev/feature
from
Absolutionism:dev/CopperGolem
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
sovdeeth
requested changes
Oct 18, 2025
sovdeeth
requested changes
Oct 18, 2025
src/main/java/ch/njol/skript/expressions/ExprCopperGolemOxidationTime.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCopperGolemOxidationTime.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCopperGolemOxidationTime.java
Outdated
Show resolved
Hide resolved
|
Forgot to write this in the last review, but this should all be in the skriptlang package. |
sovdeeth
requested changes
Oct 23, 2025
src/main/java/org/skriptlang/skript/bukkit/elements/effects/EffWax.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/elements/expressions/ExprCopperState.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/paperutil/CopperState.java
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Oct 23, 2025
sovdeeth
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No proper support for setting and getting attributes of copper golems and copper blocks.
Solution
Removes 'copper golem' from SimpleEntityData and adds CopperGolemData allowing users to specify the copper state of the copper golem and whether they're waxed.
Adds a condition to check if a copper golem or a copper block is waxed.
Adds an effect to wax or unwax a copper golem or a copper block.
Adds an expression to get/set the time until the next oxidation for a copper golem.
Adds an expression to get/set the pose of a copper golem statue.
Adds an expression to get/set the copper state of a copper golem or a copper block.
Adds 'CopperState' that mimics 'WeatheringCopperState' for the versions that don't have it. Allowing easy use for getting and setting the copper states.
Registers ClassInfo for copper golem statue poses
Registers ClassInfo for 'CopperState' or 'WeatheringCopperState' if it exists.
Adds 'ReflectUtils' that is a utility class for common reflection and caches where possible. Reflection was needed for 'CopperState', 'ExprCopperState', and 'ExprCopperGolemOxidationTime' which led to the creation of ReflectUtils.
Testing Completed
EntityData.sk
EffWax.sk
ExprCopperGolemOxidationTime.sk
ExprCopperGolemPose.sk
ExprCopperState.sk
EffSecSpawn.sk
Supporting Information
N/A
Completes: none
Related: none