Skip to content

Fix getting java functions causing casting errors #8213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Tablisted Players expression has a duplicate [the] like `[the] [the]`
merged 2 commits into from
Oct 1, 2025
Merged

Fix getting java functions causing casting errors #8213

merged 2 commits into from
Oct 1, 2025

Conversation

@Efnilite
Copy link
Member

@Efnilite Efnilite commented Oct 1, 2025 •
edited
Loading

Problem

Fix Functions#getJavaFunctions causing casting errors on call.

Solution

Makes sure that only JavaFunctions are returned when calling getJavaFunctions. This does not include DefaultFunctions, as getFunctions should be used.

Testing Completed

Manual testing.

Supporting Information

Completes: none
Related: none

@Efnilite Efnilite requested review from a team and Pikachu920 as code owners October 1, 2025 16:33
@Efnilite Efnilite requested review from cheeezburga and removed request for a team October 1, 2025 16:33
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Oct 1, 2025
Burbulinis
Burbulinis approved these changes Oct 1, 2025
View reviewed changes
@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Oct 1, 2025
@Absolutionism Absolutionism merged commit f94caa2 into dev/feature Oct 1, 2025
6 checks passed
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Oct 1, 2025
@Efnilite Efnilite deleted the feature/fix-get-java-functions branch October 4, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Absolutionism Absolutionism Absolutionism approved these changes

@Burbulinis Burbulinis Burbulinis approved these changes

@Pikachu920 Pikachu920 Awaiting requested review from Pikachu920

@cheeezburga cheeezburga Awaiting requested review from cheeezburga cheeezburga is a code owner automatically assigned from SkriptLang/core-developers

Assignees

No one assigned

Labels

completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Efnilite @sovdeeth @Absolutionism @Burbulinis