Fix 'cannot be saved' on emphemeral vars. #8024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
requested review from
Burbulinis and
TheMug06
and removed request for
a team
1 task
skriptlang-automation
bot
added
the
needs reviews
|
Just out of curiosity, since ephemeral variables are enabled by default now. Would it not be better to have an “isEphemeral” method on Variable? |
yeah that's what i meant by making the api like local vars |
ahh ok |
|
actually thinking more about this I don't think this solution is ok at all due to the evaluation problem |
sovdeeth
requested review from
UnderscoreTud and
APickledWalrus
and removed request for
a team
sovdeeth
added
the
bug
UnderscoreTud
approved these changes
Jul 13, 2025
APickledWalrus
approved these changes
Jul 15, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.12 Releases
Burbulinis
approved these changes
Jul 15, 2025
skriptlang-automation
bot
added
feature-ready
Absolutionism
approved these changes
Jul 15, 2025
skriptlang-automation
bot
added
completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ephemeral variables are not saved, yet were emitting 'cannot save x' warnings.
Solution
Adds a ephemeral field that acts identically to how local variables are determined. Variable#isEphemeral() is the public api.
Moves the static ephemeral token field from Variables to Variable to match the local token field.
Testing Completed
manual confirmation.
Supporting Information
Completes: #8023
Related: none