Skip to content

Make has potion effect types optional #8010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: dev/patch
Choose a base branch
from
Open

Make has potion effect types optional #8010

wants to merge 6 commits into from

Conversation

TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Jul 5, 2025 •
edited
Loading

Problem

User came into the skript help expecting syntax player has potion effects to be valid

Solution

Make has potion effect types optional

@TheLimeGlass TheLimeGlass requested a review from a team as a code owner July 5, 2025 15:35
@TheLimeGlass TheLimeGlass requested review from cheeezburga and erenkarakal and removed request for a team July 5, 2025 15:35
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jul 5, 2025
Absolutionism
Absolutionism suggested changes Jul 5, 2025
View reviewed changes
@Absolutionism Absolutionism added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jul 5, 2025
@Absolutionism Absolutionism moved this to In Review in 2.13 Release Jul 5, 2025
Efnilite
Efnilite requested changes Jul 5, 2025
View reviewed changes
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jul 5, 2025
@TheLimeGlass TheLimeGlass requested a review from Efnilite July 5, 2025 22:27
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jul 5, 2025
@sovdeeth sovdeeth removed this from 2.13 Release Jul 15, 2025
@sovdeeth sovdeeth changed the base branch from dev/feature to dev/patch July 16, 2025 04:27
@sovdeeth sovdeeth added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Efnilite Efnilite Efnilite approved these changes

@Absolutionism Absolutionism Absolutionism approved these changes

@cheeezburga cheeezburga Awaiting requested review from cheeezburga cheeezburga is a code owner automatically assigned from SkriptLang/core-developers

@erenkarakal erenkarakal Awaiting requested review from erenkarakal erenkarakal is a code owner automatically assigned from SkriptLang/core-developers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheLimeGlass @Efnilite @Absolutionism @sovdeeth