Literal Number Max+Min Values #8008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutionism
requested review from
UnderscoreTud and
cheeezburga
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
Absolutionism
added
the
enhancement
sovdeeth
requested changes
Jul 5, 2025
src/main/java/ch/njol/skript/test/runner/LitDoubleMaxValue.java
Outdated
Show resolved
Hide resolved
Efnilite
approved these changes
Jul 5, 2025
sovdeeth
requested changes
Jul 6, 2025
skriptlang-automation
bot
removed
the
needs reviews
sovdeeth
approved these changes
Jul 8, 2025
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.13 Release
skriptlang-automation
bot
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No expression/literal to easily grab the max/min value of a number type when needed for tests ensuring expression changer capped the final value to the specific values.
Solution
Adds literals for each number type and both max and min values.
Updates tests using the actual number representation.
Adds a new
literalspackage to store the newly created literals and existing ones.Adds
literalsin theloadClassesmethod callTesting Completed
quickTestSupporting Information
N/A
Other
These literals are only made for the testing environment. But if anyone believes it should be available outside of the testing environment, I have no problem with that.Edit: Are now available outside of test environment.
Completes: none
Related: none