-
-
Notifications
You must be signed in to change notification settings - Fork 399
Fixes async help unregister async #7962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheLimeGlass
wants to merge
5
commits into
SkriptLang:dev/patch
Choose a base branch
from
TheLimeGlass:fix/command-async-unregister
base: dev/patch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixes async help unregister async #7962
TheLimeGlass
wants to merge
5
commits into
SkriptLang:dev/patch
from
TheLimeGlass:fix/command-async-unregister
+23
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
approved these changes
Jun 20, 2025
sovdeeth
requested changes
Jun 20, 2025
sovdeeth
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine but I'd like pickle to review too
APickledWalrus
requested changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
don't merge me !!
For pull requests that should not be merged due to some outstanding dispute, conflict or dependency.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Reloading scripts asynchronously that contain commands that have already registered their commands.
I use config.sk setting
script loader thread size: 1
so this could be the culprit.Skript 2.11.2
Paper 1.21.5
Solution
Unregister help commands on the main thread. Bukkit's help system isn't thread-safe.