ExprAttachedBlock Plural Support #7897
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenkarakal
requested review from
Efnilite and
cheeezburga
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
erenkarakal
added
the
enhancement
UnderscoreTud
requested changes
May 24, 2025
src/main/java/ch/njol/skript/expressions/ExprAttachedBlock.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
May 28, 2025
|
|
||
| @Override | ||
| protected Block[] get(Event event, Projectile[] source) { | ||
| List<Block> blocks = new ArrayList<>(); |
There was a problem hiding this comment.
Thoughts on making this a Set to remove duplicate blocks?
I could see it both ways
| } | ||
|
|
||
| } | ||
| } |
skriptlang-automation
bot
removed
the
needs reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Paper deprecated the old method for being unreliable, as arrows can be attached to multiple blocks at once. The old method used to be completely broken for full blocks, but it looks like it was fixed before it was deprecated, so no errors/warnings are thrown if you use the old version.
Solution
Testing Completed
Reflection check, null values and new patterns were tested.
Supporting Information
No breaking changes
Completes: #7753
Related: Paper#12096, Paper#12099