Timezone Support #7887
Open
Timezone Support #7887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenkarakal
requested review from
Efnilite and
cheeezburga
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
sovdeeth
requested changes
May 22, 2025
sovdeeth
added
the
enhancement
ShaneBeee
reviewed
May 22, 2025
Absolutionism
suggested changes
May 22, 2025
Efnilite
approved these changes
Jun 4, 2025
erenkarakal
added
the
don't merge me !!
erenkarakal
removed
the
don't merge me !!
Absolutionism
suggested changes
Jun 4, 2025
src/main/java/ch/njol/skript/conditions/CondIsTimezoneValid.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsTimezoneValid.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDateInTimezone.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDateInTimezone.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDateInTimezone.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDateInTimezone.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Jun 6, 2025
src/main/java/ch/njol/skript/conditions/CondIsTimezoneValid.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsTimezoneValid.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsTimezoneValid.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprDateInTimezone.java
Outdated
Show resolved
Hide resolved
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
skriptlang-automation
bot
removed
the
needs reviews
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Burbulinis
requested changes
Jun 9, 2025
| public class CondIsTimezoneValid extends Condition { | ||
|
|
||
| static { | ||
| Skript.registerCondition(CondIsTimezoneValid.class, "%strings% (are|is [a[n]]) [negate:in]valid time[ ]zone[s]"); |
There was a problem hiding this comment.
Could be a property condition, and just do setNegated(isNegated() == hasTag("negate") in init()
There was a problem hiding this comment.
Yeah, I think a BE PropertyCondition would work. is a valid timezone, is not a valid timezone, is an invalid timezone, etc.
Absolutionism
approved these changes
Jun 14, 2025
src/main/java/ch/njol/skript/expressions/ExprDateInTimezone.java
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Jun 17, 2025
APickledWalrus
requested changes
Jul 1, 2025
| public class ExprAllTimezones extends SimpleLiteral<String> { | ||
|
|
||
| static { | ||
| Skript.registerExpression(ExprAllTimezones.class, String.class, ExpressionType.SIMPLE, "all [of [the]] time[ ]zones"); |
There was a problem hiding this comment.
Suggested change
| Skript.registerExpression(ExprAllTimezones.class, String.class, ExpressionType.SIMPLE, "all [of [the]] time[ ]zones"); | |
| Skript.registerExpression(ExprAllTimezones.class, String.class, ExpressionType.SIMPLE, "[the|all [[of] the]] time[ ]zones"); |
the, all the, all of the
| public class CondIsTimezoneValid extends Condition { | ||
|
|
||
| static { | ||
| Skript.registerCondition(CondIsTimezoneValid.class, "%strings% (are|is [a[n]]) [negate:in]valid time[ ]zone[s]"); |
There was a problem hiding this comment.
Yeah, I think a BE PropertyCondition would work. is a valid timezone, is not a valid timezone, is an invalid timezone, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There isn't a way to get the date in a timezone without knowing its time offset.
Solution
Adds three new syntaxes for working with time zones.
Expressions:
[the] [date[s]] %dates% in time[ ]zone %string%or[the] [date[s]] %dates% in [the] %string% time[ ]zoneall [of [the]] time[ ]zonesConditions:
%strings% (are|is [a[n]]) [negate:in]valid time[ ]zone[s]This PR also forces the test environment to use the
UTCtimezone.Testing Completed
Tests are available in timezones.sk
Supporting Information
Tests will stop failing when this is merged
Completes: none
Related: none