-
-
Notifications
You must be signed in to change notification settings - Fork 399
Get SQL databases working again #7653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/feature
Are you sure you want to change the base?
Get SQL databases working again #7653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes from @APickledWalrus in #5646 still not addressed
Closing due to change requests outstanding for 6 months (#5646 (review)) |
huh? |
Get Pickle to write the new requested changes. Open this pull request |
src/main/java/org/skriptlang/skript/variables/storage/SQLiteStorage.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
commit changes
option which is essentially how Skript used to operate. Changed the JDBC standard to auto commit after every edit (Make the 5-min variable saving period configurable #2007). This is standard and better for performance. Skript didn't for some reason. I speculate it was to allow MySQL to sync with other servers, so either way it's an option now.Perks
TODO
MERGE INTO
instead ofINSERT
.Optional
Notes:
Testing and using this jar
To test this experimental feature out, go to the "checks" tab and then click a Java version on the side and then click the nightly artifacts to get a built jar of the latest commit.
Target Minecraft Versions: any
Requirements: none
Related Issues: #1168, #2007, #1478 and #3948