Skip to content

Improve Item Frames #5604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Improve Item Frames #5604

wants to merge 5 commits into from

Conversation

TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Apr 14, 2023

Description

Improves Item Frames as Snow always wanted.

Sets the entity data pattern to

item[ ]frame(|1¦s) [(with|of) %-itemtype%] [[with rotation|rotated] %-rotation%]

for more proper support of ItemFrames while also registering ItemFrames as a classinfo for dedicated syntaxes.
Adds org.bukkit.Rotation and a utility effect for easily rotating an expression that returns a rotation and/or itemframes and rotation's self.

This enhancement was more work than I expected, so it's a decently sized pull request.

Todo

Examples:

# Spawning
spawn an item frame with lime stained glass rotated 225 degrees at target block
spawn an item frame of stone rotated 90 degrees in the direction of player from target block:
    rotate event-item frame by 90 degrees
    set item of event-item frame to lime stained glass named "example"

# EffRotate
rotate the event-item frame clockwise 2 times
rotate the event-item frame by 225 degrees

Target Minecraft Versions: any
Requirements: none
Related Issues: #414 (non-closing) and #2874

@TheLimeGlass TheLimeGlass added the feature Pull request adding a new feature. label Apr 14, 2023
@TheLimeGlass TheLimeGlass changed the title Revamp item frames Make item frames accessible Apr 14, 2023
@TheLimeGlass TheLimeGlass marked this pull request as draft April 14, 2023 11:15
@TheLimeGlass TheLimeGlass added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Apr 14, 2023
@TheLimeGlass TheLimeGlass changed the title Make item frames accessible Improve Item Frames Apr 14, 2023
@sovdeeth
Copy link
Member

Closing due to inactivity.

@sovdeeth sovdeeth closed this Jul 16, 2024
@TheLimeGlass TheLimeGlass reopened this Jul 16, 2024
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheLimeGlass
Copy link
Contributor Author

Updated #7749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants