And some bugs fixed

Author: bensku

src/main/java/ch/njol/skript/ScriptLoader.java

@@ -212,6 +212,7 @@ static ScriptInfo loadScripts() {
 			Skript.info(m_scripts_loaded.toString(i.files, i.triggers, i.commands, start.difference(new Date())));
 
 		SkriptEventHandler.registerBukkitEvents();
+		Functions.postCheck(); // Check that all functions which are called exist.
 
 		return i;
 	}

src/main/java/ch/njol/skript/events/EvtItem.java

@@ -67,12 +67,12 @@ public class EvtItem extends SkriptEvent {
 				.since("");
 		if (hasPrepareCraftEvent) {
 			Skript.registerEvent("Prepare Craft", EvtItem.class, PrepareItemCraftEvent.class, "[player] (preparing|beginning) craft[ing] [[of] %itemtypes%]")
-					.description("Called just before displaying crafting result to player. You can set the result, but not cancel the event")
+					.description("Called just before displaying crafting result to player. Note that setting the result item might or might not work due to Bukkit bugs.")
 					.examples("")
 					.since("2.2-Fixes-V10");
 		}
 		Skript.registerEvent("Pick Up", EvtItem.class, PlayerPickupItemEvent.class, "[player] (pick[ ]up|picking up) [[of] %itemtypes%]")
-				.description("Called when a player picks up an item. Note that setting the result item might or might not work due to Bukkit bugs.")
+				.description("Called when a player picks up an item. Please note that the item is still on the ground when this event is called.")
 				.examples("")
 				.since("");
 		// TODO brew event

src/main/java/ch/njol/skript/expressions/ExprPotionItem.java

@@ -53,14 +53,14 @@ public class ExprPotionItem extends SimpleExpression<ItemType> {
 		}
 	}
 
-	@SuppressWarnings("null")
+	@Nullable
 	private Expression<PotionEffectType> type;
 	private int mod = 0; // 1=upgraded, 2=extended
 	private int usage = 0; // 0=normal, 1=splash, 2=exploding
 	private boolean water = false;
 	private boolean matchAll = false;
 
-	@SuppressWarnings({"unchecked", "null"})
+	@SuppressWarnings({"unchecked"})
 	@Override
 	public boolean init(final Expression<?>[] exprs, final int matchedPattern, final Kleenean isDelayed, final ParseResult parseResult) {
 		if (matchedPattern == 2) {
@@ -121,7 +121,8 @@ public Class<? extends ItemType> getReturnType() {
 
 	@Override
 	public String toString(final @Nullable Event e, final boolean debug) {
-		if (e == null) return "bottle of water";
+		if (e == null || type == null) return "bottle of water";
+		assert type != null;
 		return PotionEffectUtils.getPotionName(type.getSingle(e), mod == 2, mod == 1);
 	}
 }

src/main/java/ch/njol/skript/lang/SkriptParser.java

@@ -752,9 +752,13 @@ public final <T> FunctionReference<T> parseFunction(final @Nullable Class<? exte
 //			}
 //			@SuppressWarnings("null")
 			final FunctionReference<T> e = new FunctionReference<T>(functionName, SkriptLogger.getNode(), ScriptLoader.currentScript != null ? ScriptLoader.currentScript.getFile() : null, types, params);//.toArray(new Expression[params.size()]));
-			if (!SkriptConfig.allowFunctionsBeforeDefs.value() && !e.validateFunction(true)) {
-				log.printError();
-				return null;
+			if (SkriptConfig.allowFunctionsBeforeDefs.value()) {
+				Functions.addPostCheck(e); // Query function for post-checking
+			} else {
+				if (!e.validateFunction(true)) {
+					log.printError();
+					return null;
+				}
 			}
 			log.printLog();
 			return e;