Finish function post-checking

Author: bensku

pom.xml

@@ -2,7 +2,7 @@
 	<modelVersion>4.0.0</modelVersion>
 	<groupId>ch.njol</groupId>
 	<artifactId>skript</artifactId>
-	<version>2.2-Fixes-V10</version>
+	<version>2.2-dev13</version>
 	<name>Skript</name>
 	<description>A plugin for the Minecraft server API Bukkit that allows to create scripts in natural language.</description>
 	<url>http://njol.ch/projects/skript/</url>

src/main/java/ch/njol/skript/SkriptConfig.java

@@ -151,7 +151,7 @@ public EventPriority convert(final String s) {
 	public final static Option<Integer> maxTargetBlockDistance = new Option<Integer>("maximum target block distance", 100);
 
 	public final static Option<Boolean> caseSensitive = new Option<Boolean>("case sensitive", false);
-	public final static Option<Boolean> allowFunctionsBeforeDefs = new Option<Boolean>("allow function calls before definations", true);
+	public final static Option<Boolean> allowFunctionsBeforeDefs = new Option<Boolean>("allow function calls before definations", false);
 
 	public final static Option<Boolean> disableVariableConflictWarnings = new Option<Boolean>("disable variable conflict warnings", false);
 	public final static Option<Boolean> disableObjectCannotBeSavedWarnings = new Option<Boolean>("disable variable will not be saved warnings", false);

src/main/java/ch/njol/skript/lang/SkriptParser.java

@@ -728,14 +728,10 @@ public final <T> FunctionReference<T> parseFunction(final @Nullable Class<? exte
 			}
 
 			final Function<?> function = Functions.getFunction(functionName);
-			if (function == null) {
-				if (SkriptConfig.allowFunctionsBeforeDefs.value()) {
-					Functions.addPostCheck(new FunctionReference<T>(functionName, SkriptLogger.getNode(), ScriptLoader.currentScript != null ? ScriptLoader.currentScript.getFile() : null, types, params));
-				} else {
-					Skript.error("The function '" + functionName + "' does not exist");
-					log.printError();
-					return null;
-				}
+			if (function == null && !SkriptConfig.allowFunctionsBeforeDefs.value()) {
+				Skript.error("The function '" + functionName + "' does not exist");
+				log.printError();
+				return null;
 			}
 
 //			final List<Expression<?>> params = new ArrayList<Expression<?>>();
@@ -756,7 +752,7 @@ public final <T> FunctionReference<T> parseFunction(final @Nullable Class<? exte
 //			}
 //			@SuppressWarnings("null")
 			final FunctionReference<T> e = new FunctionReference<T>(functionName, SkriptLogger.getNode(), ScriptLoader.currentScript != null ? ScriptLoader.currentScript.getFile() : null, types, params);//.toArray(new Expression[params.size()]));
-			if (!e.validateFunction(true)) {
+			if (!SkriptConfig.allowFunctionsBeforeDefs.value() && !e.validateFunction(true)) {
 				log.printError();
 				return null;
 			}

src/main/java/ch/njol/skript/lang/function/Functions.java

@@ -241,13 +241,18 @@ public final static void addPostCheck(FunctionReference<?> ref) {
 	}
 
 	public final static void postCheck() {
-		for (FunctionReference<?> ref : postCheckNeeded) {
+		if (postCheckNeeded.isEmpty()) return;
+		
+		final ParseLogHandler log = SkriptLogger.startParseLogHandler();
+		for (final FunctionReference<?> ref : postCheckNeeded) {
 			if (!ref.validateFunction(true)) {
-				// TODO Do something
+				log.printError();
 			}
 		}
+		log.printLog();
 
 		postCheckNeeded.clear();
+		log.stop();
 	}
 
 }

src/main/resources/config.sk

@@ -145,9 +145,10 @@ case sensitive: false
 # This e.g. applies to the effect 'replace' and the conditions 'contains' and 'is/is not'.
 # Variable names are case-insensitive irrespective of this setting.
 
-allow function calls before definations: true
+allow function calls before definations: false
 # Whether scripts should be allowed to call functions that are not yet defined.
-# If enabled, functions' existence are checked after loading ALL scripts.
+# If enabled, functions' existences are checked after loading ALL scripts.
+# Warning: Unless you have text editor with good directory-search, it can be hard to find your functions!
 
 disable variable conflict warnings: false
 # Disables warnings of potential variable name conflicts if set to true.