Skip to content

[ahmedsa] Spack exercise #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions package.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Copyright 2013-2024 Lawrence Livermore National Security, LLC and other
# Spack Project Developers. See the top-level COPYRIGHT file for details.
#
# SPDX-License-Identifier: (Apache-2.0 OR MIT)

# ----------------------------------------------------------------------------
# spack install spack-exercise
#
# You can edit this file again by typing:
#
# spack edit spack-exercise
#
# See the Spack documentation for more information on packaging.
# ----------------------------------------------------------------------------

from spack.package import *


class SpackExercise(CMakePackage):
# SPACK Exercise for the SSE Course

homepage = "https://simulation-software-engineering.github.io/homepage/"
url = "https://github.com/Simulation-Software-Engineering/spack-exercise/archive/refs/tags/v0.3.0.tar.gz"
git = "https://github.com/Simulation-Software-Engineering/spack-exercise.git"

maintainers("SyedMustafaAhmad")

license("MIT", checked_by="SyedMustafaAhmad")

version("0.3.0", sha256="e54a4c037941d85a22fb3e6e73195df8448cf69a96aa44ef374ac518344812f0")
version("0.2.0", sha256="3dd6b4cc0f7aff179d8e290bc3879056237ae372738a4bd7222f6450fbcdfc77")
version("0.1.0", sha256="cac78e641cb703e3fe51956f91fe8347ac52f74ef037d8eadae5777c65a19a00")

depends_on("cxx", type="build")
depends_on("boost", when="spack-exercise@0.2.0:")
depends_on("yaml-cpp", when="spack-exercise@0.3.0:")
Comment on lines +35 to +36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends_on("boost", when="spack-exercise@0.2.0:")
depends_on("yaml-cpp", when="spack-exercise@0.3.0:")
depends_on("boost@1.65.1:", when="spack-exercise@0.2.0:")
depends_on("yaml-cpp@0.7.0:", when="spack-exercise@0.3.0:")

The versions of the dependencies need to be enforced explicitly.


def cmake_args(self):
args = []
return args
Comment on lines +38 to +40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def cmake_args(self):
args = []
return args