Skip to content

Implement pin change callback subscriptions #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 3, 2025
Merged

Implement pin change callback subscriptions #197

merged 5 commits into from
Mar 3, 2025

Conversation

karolzwolak
Copy link
Contributor

Implements #177

@karolzwolak karolzwolak requested a review from a team as a code owner February 27, 2025 13:42
Mateusz-Krajewski
Mateusz-Krajewski requested changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@Mateusz-Krajewski Mateusz-Krajewski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ogolnie wygląda Git, ale musze sprawdzić czy działa + troche duzy commitów

@Mateusz-Krajewski Mateusz-Krajewski linked an issue Feb 27, 2025 that may be closed by this pull request
Add Callback for GPIO pin change for register service #177
Closed
4 tasks
@Mateusz-Krajewski Mateusz-Krajewski added the enhancement New feature or request label Feb 27, 2025
@Mateusz-Krajewski Mateusz-Krajewski added this to the V 1.0 milestone Feb 27, 2025
@karolzwolak
Copy link
Contributor Author

Jak coś to nic nie zmieniałem od kiedy ci pisałem, no i można będzie zquashować do 1 commita jak poprawimy wszystko.

@karolzwolak karolzwolak force-pushed the pin_callbacks branch 5 times, most recently from 5b749de to 292f699 Compare February 27, 2025 19:36
Mateusz-Krajewski
Mateusz-Krajewski reviewed Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@Mateusz-Krajewski Mateusz-Krajewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jak upewnie sie ze dziala to zmienie na aprove

Mateusz-Krajewski
Mateusz-Krajewski previously approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@Mateusz-Krajewski Mateusz-Krajewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git

@Mateusz-Krajewski Mateusz-Krajewski added this pull request to the merge queue Feb 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2025
@Mateusz-Krajewski Mateusz-Krajewski added this pull request to the merge queue Mar 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 1, 2025
@Mateusz-Krajewski Mateusz-Krajewski added this pull request to the merge queue Mar 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 1, 2025
@Mateusz-Krajewski Mateusz-Krajewski merged commit d28a864 into master Mar 3, 2025
7 checks passed
@Mateusz-Krajewski Mateusz-Krajewski deleted the pin_callbacks branch March 3, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mateusz-Krajewski Mateusz-Krajewski Mateusz-Krajewski left review comments

@bartoszsnieg bartoszsnieg Awaiting requested review from bartoszsnieg bartoszsnieg is a code owner

Assignees

@karolzwolak karolzwolak

Labels
enhancement New feature or request
Projects
None yet
Milestone
V 1.0
Development

Successfully merging this pull request may close these issues.

Add Callback for GPIO pin change for register service
2 participants
@karolzwolak @Mateusz-Krajewski