-
Notifications
You must be signed in to change notification settings - Fork 199
Add Experimental MCP Support #3396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
st0012
wants to merge
13
commits into
main
Choose a base branch
from
mcp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+921
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
ec7daf7
to
9a95003
Compare
Signed-off-by: Stan Lo <stan.lo@shopify.com>
Prajjwal
reviewed
May 28, 2025
e8bc04b
to
68f6997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
server
This pull request should be included in the server gem's release notes
vscode
This pull request should be included in the VS Code extension's release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Model Context Protocol (MCP) support to Ruby LSP
This PR adds support for the Model Context Protocol (MCP), enabling AI assistants to programmatically access Ruby project indexes and file contents that Ruby LSP already collects.
Connection Mechanism
The implementation uses a hybrid approach:
ruby-mcp-bridge
) connects the editor's MCP client to our HTTP serverArchitecture Diagram
Editor Setup
VS Code Configuration
Add to
.vscode/mcp.json
:See VS Code MCP documentation for more details.
Cursor Configuration
Add to
.cursor/mcp.json
:See Cursor MCP documentation for more details.
Notes For Manual Testing
This feature requires both the extension and server changes to work. So for testing:
gem "ruby-lsp", github: "Shopify/ruby-lsp", branch: "mcp"
Known Issues
gets
in the LSP communication channel. This issue may be specific to Cursor as it doesn't occur (or occurs much less frequently) in VS Code, and more often in certain projects (e.g.ruby/irb
) than others. The cause may be related to how Cursor handles MCP/LSP requests and requires more investigation.Supported Tools (TBD)
The MCP server provides four tools:
read_ruby_files - Access file contents, including from dependenciesThese tools enable AI assistants to understand Ruby code structure, navigate dependencies, and access relevant documentation that are not accessible through the editor's simple codebase indexing.