Skip to content

Connect to localhost server dialog #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 28, 2024

Conversation

ComicSAS
Copy link
Collaborator

@ComicSAS ComicSAS commented Jul 28, 2024

Description

Via issue

  • Implemented connect to localhost with ssh-tunneling warning dialog
  • Updated README.md

Video

video5271806484479495408.mp4

Checklist

  • I have ensured this PR does not contain any breaking changes for existing functionality;
  • I have added automated tests that cover the new behavior and removed obsolete tests and code;

Tested On

P.S. Feature requires testing via localhost(127.0.0.1) with ssh-tunneling enabled.

@ComicSAS ComicSAS self-assigned this Jul 28, 2024
@ComicSAS ComicSAS requested a review from ShiftHackZ July 28, 2024 08:23
@ShiftHackZ ShiftHackZ linked an issue Jul 28, 2024 that may be closed by this pull request
@ShiftHackZ ShiftHackZ added the enhancement New feature or request label Jul 28, 2024
Copy link
Owner

@ShiftHackZ ShiftHackZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ComicSAS Can not build from your upstream branch. Seems like string resource yes_i_did is missing in string resources.

image

@ComicSAS
Copy link
Collaborator Author

@ComicSAS Can not build from your upstream branch. Seems like string resource yes_i_did is missing in string resources.

image

@ComicSAS ComicSAS closed this Jul 28, 2024
@ShiftHackZ ShiftHackZ reopened this Jul 28, 2024
@ComicSAS
Copy link
Collaborator Author

@ComicSAS Can not build from your upstream branch. Seems like string resource yes_i_did is missing in string resources.

image

Fixed.

Copy link
Owner

@ShiftHackZ ShiftHackZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, verified that it works with Termux SSH tunnel.

@ShiftHackZ ShiftHackZ merged commit a1edcc7 into master Jul 28, 2024
1 check passed
@ShiftHackZ ShiftHackZ deleted the feature/connect_to_localhost_server_dialog branch July 28, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't connect to the server via localhost
2 participants