Em improvements #21
Open
Em improvements #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to finish editing resources/version.json to add the update reason. Scroll down in the file and you will see what I mean. Fix that and I'll merge the PR. |
|
Again denied because it is a incomplete PR. |
|
Got it. Sorry, I wasn't aware of this. |
|
If you fix it ill merge the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
I added the possibility of setting the power offset for each channel based on the reading from the provider energy meter.
Also, I switched the energy value from Wh to kWh. This is common in Europe.
I hope that this will help the community. For me is really useful because I can copy and paste the values from here when I need to enter the reading to the electricity provider.
I fixed the issue that you mentioned in #20 .
Thank you