Add optional serde support for *Type enums #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to save the change before commiting
|
Not sure how to deal with the clippy unsafe check :/ |
|
Sounds like a good lint in theory, but not helpful in this case. You can just |
uklotzde
suggested changes
Aug 2, 2025
There was a problem hiding this comment.
@Serial-ATA I tried to explain why I think this is a really bad idea. But it's your decision.
Too confusing, doesn't actually serialize to the actual MIME strings, just the enum variant names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional serde support for
FileType,MimeType,PictureType, andTagType.Let me know if I should remove/add some types.
Resolves #533 partially.