ItemKey: Remove ItemKey::Unknown
#526
Merged
+312
−430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ItemKey::Unknown` has served its purpose, and has had better alternatives for a couple of years now. It's been a source of confusion numerous times, and its existence also requires extra verification logic on conversions. `ItemKey` is finally `Copy` now too 🎉
Serial-ATA
force-pushed
the
remove-unknown
branch
from
d320371 to
069b925
Compare
Serial-ATA
force-pushed
the
remove-unknown
branch
from
981808e to
1ec22ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ItemKey::Unknownhas served its purpose, and has had better alternatives for a couple of years now. It's been a source of confusion numerous times, and its existence also requires extra verification logic on conversions.ItemKeyis finallyCopynow too 🎉closes #521