Add ID2D1PixelShaderDescriptor<T>.EffectFactory and remove runtime delegate marshalling
#907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
enhancement ✨
Sergio0694
force-pushed
the
dev/remove-delegate-marshalling
branch
2 times, most recently
from
699d64e to
06983ab
Compare
|
Saves ~17 KB in a minimal native library, and drops all the delegate marshalling logic:
|
Sergio0694
force-pushed
the
dev/remove-delegate-marshalling
branch
from
06983ab to
f909936
Compare
Sergio0694
force-pushed
the
dev/remove-delegate-marshalling
branch
from
f909936 to
bf354d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ComputeSharp.D2D1 infrastructure is currently relying on
Marshal.GetFunctionPointerForDelegateto marshal a wrapper object for a givenTin a non-generic way, such that the internalID2D1EffectImplobject can call the methods on it. This works, but it's not efficient, and also means you cannot use ComputeSharp in heavily constrained/sandboxed environments, whereMarshal.GetFunctionPointerForDelegateis not allowed (as it requires the runtime to allocate a thunk of executable memory at runtime). This PR addresses both problems having the generator emit a non-generic native factory instead.