Skip to content

Use explicit nullable type on parameter arguments (for PHP 8.4) #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

HamishSlater
Copy link
Contributor

Implicitly marking parameter $... as nullable is deprecated in PHP 8.4. The explicit nullable type must be used instead.

Implicitly marking parameter $... as nullable is deprecated in PHP
8.4. The explicit nullable type must be used instead.
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (46823e0) to head (9b31021).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #259   +/-   ##
=========================================
  Coverage     87.38%   87.38%           
  Complexity      372      372           
=========================================
  Files            36       36           
  Lines          1094     1094           
=========================================
  Hits            956      956           
  Misses          138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeroenDeDauw JeroenDeDauw merged commit 02ccd8c into SemanticMediaWiki:master Jun 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants