-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update Python logging examples in documentation. #2206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds information to the logging docs in `documentation/webdriver/troubleshooting/`` for setting up log handlers in Python. This is necessary to get log output.
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
Show resolved
Hide resolved
@Delta456 Let me know what you think. |
This is a better way than what I originally proposed. Thanks! |
@Delta456 Do you have access to merge this? (I don't). If not, who needs to pull the trigger to land this in trunk? |
I also don't have access to merge this. @harsha509 or any other TLC member can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cgoldberg !
* Update Python logging examples in documentation. This adds information to the logging docs in `documentation/webdriver/troubleshooting/`` for setting up log handlers in Python. This is necessary to get log output. * Add file logging to Python logging examples --------- Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> e4f3470
User description
Description
This adds information to the logging docs in
documentation/webdriver/troubleshooting/
for setting up log handlers in Python.Fixes SeleniumHQ/selenium #15359
Motivation and Context
The examples were incomplete and this is necessary to show how to get log output in Python.
Types of changes
Checklist
PR Type
Documentation
Description
Added Python logging handler examples to documentation.
Updated logging examples in English, Japanese, Portuguese, and Chinese.
Improved clarity on setting up Python log handlers.
Changes walkthrough 📝
logging.en.md
Add Python logging handler example in English documentation
website_and_docs/content/documentation/webdriver/troubleshooting/logging.en.md
StreamHandler
andFileHandler
usage for console logs.logging.ja.md
Add Python logging handler example in Japanese documentation
website_and_docs/content/documentation/webdriver/troubleshooting/logging.ja.md
StreamHandler
andFileHandler
usage for console logs.logging.pt-br.md
Add Python logging handler example in Portuguese documentation
website_and_docs/content/documentation/webdriver/troubleshooting/logging.pt-br.md
StreamHandler
andFileHandler
usage for console logs.logging.zh-cn.md
Add Python logging handler example in Chinese documentation
website_and_docs/content/documentation/webdriver/troubleshooting/logging.zh-cn.md
StreamHandler
andFileHandler
usage for console logs.