Skip to content

chore(deps): update dependency rubocop-rspec to v3.4.0 #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 20, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop-rspec (changelog) 3.3.0 -> 3.4.0 age adoption passing confidence

Release Notes

rubocop/rubocop-rspec (rubocop-rspec)

v3.4.0

Compare Source

  • Fix RSpec/SortMetadata cop to limit sorting to trailing metadata arguments. ([@​cbliard])
  • Replace RSpec/StringAsInstanceDoubleConstant with RSpec/VerifiedDoubleReference configured to only support constant class references. ([@​corsonknowles])
  • Fix RSpec/EmptyExampleGroup cop false positive when a simple conditional is used inside an iterator. ([@​lovro-bikic])

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit a0f4c65
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/678e7dbf35c935000810b77a
😎 Deploy Preview https://deploy-preview-2133--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

qodo-merge-pro bot commented Jan 20, 2025

CI Feedback 🧐

(Feedback updated until commit a0f4c65)

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: tests (windows, stable)

Failed stage: Run tests [❌]

Failed test name: Internet Explorer Service logs to file

Failure summary:

The RSpec tests failed after 3 attempts due to Internet Explorer service connectivity issues:

  • Failed to establish TCP connection to Internet Explorer driver service on port 5556 (connection
    refused)
  • Multiple test cases related to Internet Explorer service failed with the same connection error
  • Key failures were in tests checking IE service logging capabilities and console output
  • The errors suggest the Internet Explorer driver service was not starting properly or was unreachable

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Microsoft Windows Server 2022
    ...
    
    350:  timeout_minutes: 20
    351:  max_attempts: 3
    352:  command: cd examples/ruby
    353:  bundle exec rspec
    354:  
    355:  retry_wait_seconds: 10
    356:  polling_interval_seconds: 1
    357:  warning_on_retry: true
    358:  continue_on_error: false
    ...
    
    432:  from C:/hostedtoolcache/windows/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:45:in 'RSpec::Core::Runner.invoke'
    433:  from C:/hostedtoolcache/windows/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/rspec-core-3.13.0/exe/rspec:4:in '<top (required)>'
    434:  from C:/hostedtoolcache/windows/Ruby/3.4.1/x64/bin/rspec:25:in 'Kernel#load'
    435:  from C:/hostedtoolcache/windows/Ruby/3.4.1/x64/bin/rspec:25:in '<main>'
    436:  ....
    437:  Pending: (Failures listed here are expected and do not affect your suite's status)
    438:  1) Keys copy and paste
    439:  # Test guarded; Guarded by {browser: :chrome, reason: "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    440:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    441:  expected: "SeleniumSelenium!"
    442:  got: "!"
    443:  (compared using ==)
    444:  # ./spec/actions_api/keys_spec.rb:76:in 'block (2 levels) in <top (required)>'
    445:  2) Network waits for downloads
    446:  # Test guarded; Guarded by {platform: :windows, reason: "No reason given"};
    447:  Failure/Error: expect { Selenium::WebDriver::Wait.new.until { @completed } }.not_to raise_exception
    448:  expected no Exception, got #<Selenium::WebDriver::Error::TimeoutError: timed out after 5 seconds> with backtrace:
    ...
    
    542:  33) Element Locators with relative locators finds near element
    543:  # These are reference following the documentation example
    544:  # ./spec/elements/locators_spec.rb:55
    545:  34) Element Locators with relative locators chains relative locators
    546:  # These are reference following the documentation example
    547:  # ./spec/elements/locators_spec.rb:59
    548:  Failures:
    549:  1) Internet Explorer Options sets the file upload dialog timeout
    550:  Failure/Error: driver.quit
    551:  Net::ReadTimeout:
    552:  Net::ReadTimeout with #<TCPSocket:(closed)>
    553:  # ./spec/browsers/internet_explorer_spec.rb:31:in 'block (3 levels) in <top (required)>'
    554:  2) Internet Explorer Options ensures a clean session
    555:  Failure/Error: driver.quit
    556:  Net::ReadTimeout:
    557:  Net::ReadTimeout with #<TCPSocket:(closed)>
    558:  # ./spec/browsers/internet_explorer_spec.rb:37:in 'block (3 levels) in <top (required)>'
    559:  3) Internet Explorer Service logs to file
    560:  Failure/Error: config.after { @driver&.quit }
    561:  Errno::ECONNREFUSED:
    562:  Failed to open TCP connection to 127.0.0.1:5556 (No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556)
    563:  # ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    564:  # ------------------
    565:  # --- Caused by: ---
    566:  # Errno::ECONNREFUSED:
    567:  #   No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556
    568:  #   ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    569:  Finished in 14 minutes 40 seconds (files took 43.01 seconds to load)
    570:  185 examples, 3 failures, 34 pending
    571:  Failed examples:
    572:  rspec ./spec/browsers/internet_explorer_spec.rb:28 # Internet Explorer Options sets the file upload dialog timeout
    573:  rspec ./spec/browsers/internet_explorer_spec.rb:34 # Internet Explorer Options ensures a clean session
    574:  rspec ./spec/browsers/internet_explorer_spec.rb:79 # Internet Explorer Service logs to file
    575:  ##[warning]Attempt 1 failed. Reason: Child_process exited with error code 1
    ...
    
    631:  from C:/hostedtoolcache/windows/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:45:in 'RSpec::Core::Runner.invoke'
    632:  from C:/hostedtoolcache/windows/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/rspec-core-3.13.0/exe/rspec:4:in '<top (required)>'
    633:  from C:/hostedtoolcache/windows/Ruby/3.4.1/x64/bin/rspec:25:in 'Kernel#load'
    634:  from C:/hostedtoolcache/windows/Ruby/3.4.1/x64/bin/rspec:25:in '<main>'
    635:  ....
    636:  Pending: (Failures listed here are expected and do not affect your suite's status)
    637:  1) Keys copy and paste
    638:  # Test guarded; Guarded by {browser: :chrome, reason: "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    639:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    640:  expected: "SeleniumSelenium!"
    641:  got: "!"
    642:  (compared using ==)
    643:  # ./spec/actions_api/keys_spec.rb:76:in 'block (2 levels) in <top (required)>'
    644:  2) Network waits for downloads
    645:  # Test guarded; Guarded by {platform: :windows, reason: "No reason given"};
    646:  Failure/Error: expect { Selenium::WebDriver::Wait.new.until { @completed } }.not_to raise_exception
    647:  expected no Exception, got #<Selenium::WebDriver::Error::TimeoutError: timed out after 5 seconds> with backtrace:
    ...
    
    741:  33) Element Locators with relative locators finds near element
    742:  # These are reference following the documentation example
    743:  # ./spec/elements/locators_spec.rb:55
    744:  34) Element Locators with relative locators chains relative locators
    745:  # These are reference following the documentation example
    746:  # ./spec/elements/locators_spec.rb:59
    747:  Failures:
    748:  1) Internet Explorer Service logs to file
    749:  Failure/Error: config.after { @driver&.quit }
    750:  Errno::ECONNREFUSED:
    751:  Failed to open TCP connection to 127.0.0.1:5556 (No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556)
    752:  # ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    753:  # ------------------
    754:  # --- Caused by: ---
    755:  # Errno::ECONNREFUSED:
    756:  #   No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556
    757:  #   ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    758:  2) Internet Explorer Service logs to console
    759:  Failure/Error: config.after { @driver&.quit }
    760:  Errno::ECONNREFUSED:
    761:  Failed to open TCP connection to 127.0.0.1:5556 (No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556)
    762:  # ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    763:  # ------------------
    764:  # --- Caused by: ---
    765:  # Errno::ECONNREFUSED:
    766:  #   No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556
    767:  #   ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    768:  3) Internet Explorer Service sets log level
    769:  Failure/Error: config.after { @driver&.quit }
    770:  Errno::ECONNREFUSED:
    771:  Failed to open TCP connection to 127.0.0.1:5556 (No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556)
    772:  # ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    773:  # ------------------
    774:  # --- Caused by: ---
    775:  # Errno::ECONNREFUSED:
    776:  #   No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556
    777:  #   ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    778:  4) Internet Explorer Service sets location for supporting files
    779:  Failure/Error: config.after { @driver&.quit }
    780:  Errno::ECONNREFUSED:
    781:  Failed to open TCP connection to 127.0.0.1:5556 (No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556)
    782:  # ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    783:  # ------------------
    784:  # --- Caused by: ---
    785:  # Errno::ECONNREFUSED:
    786:  #   No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556
    787:  #   ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    788:  Finished in 9 minutes 56 seconds (files took 3.09 seconds to load)
    789:  185 examples, 4 failures, 34 pending
    790:  Failed examples:
    791:  rspec ./spec/browsers/internet_explorer_spec.rb:79 # Internet Explorer Service logs to file
    792:  rspec ./spec/browsers/internet_explorer_spec.rb:88 # Internet Explorer Service logs to console
    793:  rspec ./spec/browsers/internet_explorer_spec.rb:98 # Internet Explorer Service sets log level
    794:  rspec ./spec/browsers/internet_explorer_spec.rb:109 # Internet Explorer Service sets location for supporting files
    795:  ##[warning]Attempt 2 failed. Reason: Child_process exited with error code 1
    ...
    
    846:  from C:/hostedtoolcache/windows/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:45:in 'RSpec::Core::Runner.invoke'
    847:  from C:/hostedtoolcache/windows/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/rspec-core-3.13.0/exe/rspec:4:in '<top (required)>'
    848:  from C:/hostedtoolcache/windows/Ruby/3.4.1/x64/bin/rspec:25:in 'Kernel#load'
    849:  from C:/hostedtoolcache/windows/Ruby/3.4.1/x64/bin/rspec:25:in '<main>'
    850:  ....
    851:  Pending: (Failures listed here are expected and do not affect your suite's status)
    852:  1) Keys copy and paste
    853:  # Test guarded; Guarded by {browser: :chrome, reason: "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    854:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    855:  expected: "SeleniumSelenium!"
    856:  got: "!"
    857:  (compared using ==)
    858:  # ./spec/actions_api/keys_spec.rb:76:in 'block (2 levels) in <top (required)>'
    859:  2) Network waits for downloads
    860:  # Test guarded; Guarded by {platform: :windows, reason: "No reason given"};
    861:  Failure/Error: expect { Selenium::WebDriver::Wait.new.until { @completed } }.not_to raise_exception
    862:  expected no Exception, got #<Selenium::WebDriver::Error::TimeoutError: timed out after 5 seconds> with backtrace:
    ...
    
    956:  33) Element Locators with relative locators finds near element
    957:  # These are reference following the documentation example
    958:  # ./spec/elements/locators_spec.rb:55
    959:  34) Element Locators with relative locators chains relative locators
    960:  # These are reference following the documentation example
    961:  # ./spec/elements/locators_spec.rb:59
    962:  Failures:
    963:  1) Internet Explorer Service logs to file
    964:  Failure/Error: config.after { @driver&.quit }
    965:  Errno::ECONNREFUSED:
    966:  Failed to open TCP connection to 127.0.0.1:5556 (No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556)
    967:  # ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    968:  # ------------------
    969:  # --- Caused by: ---
    970:  # Errno::ECONNREFUSED:
    971:  #   No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556
    972:  #   ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    973:  2) Internet Explorer Service logs to console
    974:  Failure/Error: config.after { @driver&.quit }
    975:  Errno::ECONNREFUSED:
    976:  Failed to open TCP connection to 127.0.0.1:5556 (No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556)
    977:  # ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    978:  # ------------------
    979:  # --- Caused by: ---
    980:  # Errno::ECONNREFUSED:
    981:  #   No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556
    982:  #   ./spec/spec_helper.rb:28:in 'block (2 levels) in <top (required)>'
    983:  Finished in 8 minutes 45 seconds (files took 3.11 seconds to load)
    984:  185 examples, 2 failures, 34 pending
    985:  Failed examples:
    986:  rspec ./spec/browsers/internet_explorer_spec.rb:79 # Internet Explorer Service logs to file
    987:  rspec ./spec/browsers/internet_explorer_spec.rb:88 # Internet Explorer Service logs to console
    988:  ##[error]Final attempt failed. Child_process exited with error code 1
    

    @VietND96 VietND96 merged commit 2e5d551 into trunk Jan 21, 2025
    9 of 12 checks passed
    @VietND96 VietND96 deleted the renovate/rubocop-rspec-3.x-lockfile branch January 21, 2025 01:00
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant