Skip to content

fixed explicit wait javascript example #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shbenzer
Copy link
Contributor

@shbenzer shbenzer commented Aug 28, 2024

User description

Explicit wait's javascript example referenced the wrong line - i fixed it in all translations

Description

changed line reference in explicit wait's javascript example from 50 to 52 in wait.spec.js

Motivation and Context

fixing code example

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation


Description

  • Corrected the line reference in the JavaScript example for explicit waits across multiple language translations.
  • Ensured consistency in documentation by updating the line reference from 50 to 52 in the JavaScript code example.

Changes walkthrough 📝

Relevant files
Documentation
waits.en.md
Corrected line reference in JavaScript example (English) 

website_and_docs/content/documentation/webdriver/waits.en.md

  • Updated JavaScript example line reference from 50 to 52.
+1/-1     
waits.ja.md
Corrected line reference in JavaScript example (Japanese)

website_and_docs/content/documentation/webdriver/waits.ja.md

  • Updated JavaScript example line reference from 50 to 52.
+1/-1     
waits.pt-br.md
Corrected line reference in JavaScript example (Portuguese)

website_and_docs/content/documentation/webdriver/waits.pt-br.md

  • Updated JavaScript example line reference from 50 to 52.
+1/-1     
waits.zh-cn.md
Corrected line reference in JavaScript example (Chinese) 

website_and_docs/content/documentation/webdriver/waits.zh-cn.md

  • Updated JavaScript example line reference from 50 to 52.
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link

netlify bot commented Aug 28, 2024

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d2b27ec

@qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation Review effort [1-5]: 1 labels Aug 28, 2024
Copy link
Contributor

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shbenzer !

@harsha509 harsha509 merged commit eb529a8 into SeleniumHQ:trunk Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Review effort [1-5]: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants