Skip to content

Update dependency selenium to v4.21.0 #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/python/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
selenium==4.20.0
selenium==4.21.0
pytest
trio
pytest-trio
Expand Down
2 changes: 1 addition & 1 deletion examples/python/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def server():

process = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)

def wait_for_server(url, timeout=20):
def wait_for_server(url, timeout=60):
start = time.time()
while time.time() - start < timeout:
try:
Expand Down
5 changes: 5 additions & 0 deletions examples/python/tests/drivers/test_remote_webdriver.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
import os
import sys

import pytest
from selenium import webdriver
from selenium.webdriver.common.by import By
from selenium.webdriver.remote.file_detector import LocalFileDetector
from selenium.webdriver.support.wait import WebDriverWait


@pytest.mark.skipif(sys.platform == "win32", reason="Gets stuck on Windows, passes locally")
def test_start_remote(server):
options = webdriver.ChromeOptions()
driver = webdriver.Remote(command_executor=server, options=options)
Expand All @@ -14,6 +17,7 @@ def test_start_remote(server):
driver.quit()


@pytest.mark.skipif(sys.platform == "win32", reason="Gets stuck on Windows, passes locally")
def test_uploads(server):
options = webdriver.ChromeOptions()
driver = webdriver.Remote(command_executor=server, options=options)
Expand All @@ -33,6 +37,7 @@ def test_uploads(server):
assert file_name == "selenium-snapshot.png"


@pytest.mark.skipif(sys.platform == "win32", reason="Gets stuck on Windows, passes locally")
def test_downloads(server, temp_dir):
options = webdriver.ChromeOptions()
options.enable_downloads = True
Expand Down
Loading