[rust] Fix Windows arm64 logic for Selenium Manager and prepare CI for running the test suite #16046
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
#15801
💥 What does this PR do?
This PR fixes two issues that were preventing the Rust test suite to fully pass on Windows on ARM. While running the tests locally on an arm64 machine, I ran into these errors:
and
It turned out that the arch names for Windows arm64 were incorrect in the Rust code. Confirmed that these are valid URLs:
I want to emphasize that Windows ARM64 can run x64 binaries under emulation. So even though e.g. Chrome doesn't have a native Chromedriver yet, Windows ARM64 can run the x64 version under emulation.
This means that the following browsers/drivers will work on Windows ARM64:
I can confirm that the Rust test suite is passing locally on my Windows arm64 machine.
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Bug fix
Description
Fix Windows ARM64 platform labels in Selenium Manager
Correct Firefox ARM64 URL path from
win-aarch64
towin64-aarch64
Fix Electron ARM64 platform label from
win32-arm64-x64
towin32-arm64
Add Windows ARM64 CI testing support
Changes diagram
Changes walkthrough 📝
electron.rs
Correct Electron ARM64 platform label
rust/src/electron.rs
win32-arm64-x64
towin32-arm64
firefox.rs
Correct Firefox ARM64 platform label
rust/src/firefox.rs
win-aarch64
towin64-aarch64
ci-rust.yml
Enable Windows ARM64 CI testing
.github/workflows/ci-rust.yml
windows-11-arm
to CI test matrix