[rb] Remove local storage and session storage interfaces and methods #16015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
fixes #10397
there are no mentions for removed classes and related interfaces according to docs
💥 What does this PR do?
This pull request removes support for local and session storage functionality from the Selenium WebDriver library. The changes include the removal of related classes, modules, methods, and interfaces.
Removal of Local and Session Storage Features:
rb/sig/interfaces/local_storage.rbs
: Removed the_LocalStorage
interface, which defined thekeys
method.rb/sig/lib/selenium/webdriver/common/html5/local_storage.rbs
: Removed theLocalStorage
class, including its methods (keys
,size
,clear
, etc.) and theSharedWebStorage
inclusion.rb/sig/lib/selenium/webdriver/common/html5/session_storage.rbs
: Removed theSessionStorage
class, including its methods (keys
,size
,clear
, etc.) and theSharedWebStorage
inclusion.rb/sig/lib/selenium/webdriver/common/html5/shared_web_storage.rbs
: Removed theSharedWebStorage
module, which included methods for interacting with storage (key?
,fetch
,empty?
, etc.) and the_LocalStorage
inclusion.Removal of Related Methods in Remote Bridge:
rb/sig/lib/selenium/webdriver/remote/bridge.rbs
: Removed methods for interacting with local and session storage (local_storage_item
,remove_local_storage_item
,local_storage_keys
,clear_local_storage
,local_storage_size
,session_storage_item
,remove_session_storage_item
,session_storage_keys
,clear_session_storage
,session_storage_size
).🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Other
Description
Remove HTML5 local storage and session storage classes
Delete SharedWebStorage module and LocalStorage interface
Remove storage-related methods from remote bridge
Clean up deprecated HTML5 storage functionality
Changes diagram
Changes walkthrough 📝
local_storage.rbs
Remove LocalStorage interface
rb/sig/interfaces/local_storage.rbs
_LocalStorage
interface definitionkeys
method signaturelocal_storage.rbs
Remove LocalStorage class
rb/sig/lib/selenium/webdriver/common/html5/local_storage.rbs
LocalStorage
class[]
,[]=
,delete
,clear
,size
,keys
)SharedWebStorage
inclusionsession_storage.rbs
Remove SessionStorage class
rb/sig/lib/selenium/webdriver/common/html5/session_storage.rbs
SessionStorage
classEnumerable
inclusionSharedWebStorage
inclusionshared_web_storage.rbs
Remove SharedWebStorage module
rb/sig/lib/selenium/webdriver/common/html5/shared_web_storage.rbs
SharedWebStorage
modulekey?
,fetch
,empty?
,each
)Enumerable
and_LocalStorage
inclusionsbridge.rbs
Remove storage methods from bridge
rb/sig/lib/selenium/webdriver/remote/bridge.rbs
local_storage_item
,remove_local_storage_item
, etc.)session_storage_item
,remove_session_storage_item
, etc.)