[build] Ensure all valid ruby tests are running on RBE

.bazelrc.remote

@@ -11,7 +11,7 @@ build:rbe --define=EXECUTOR=remote
 build:rbe --experimental_inmemory_dotd_files
 build:rbe --experimental_inmemory_jdeps_files
 build:rbe --remote_timeout=3600
-build:rbe --spawn_strategy=remote,local
+build:rbe --spawn_strategy=remote
 #build:rbe --nolegacy_important_outputs
 build:rbe --incompatible_strict_action_env=true
 

.skipped-tests

@@ -22,29 +22,4 @@
 -//javascript/selenium-webdriver:test-builder-test.js-chrome
 -//javascript/selenium-webdriver:test-chrome-devtools-test.js-chrome
 -//javascript/selenium-webdriver:test-firefox-options-test.js-firefox
--//rb/spec/integration/selenium/webdriver/chrome:service-chrome
--//rb/spec/integration/selenium/webdriver/chrome:service-chrome-bidi
--//rb/spec/integration/selenium/webdriver/chrome:service-chrome-remote
--//rb/spec/integration/selenium/webdriver/edge:service-edge
--//rb/spec/integration/selenium/webdriver/edge:service-edge-bidi
--//rb/spec/integration/selenium/webdriver/edge:service-edge-remote
--//rb/spec/integration/selenium/webdriver/firefox:driver-firefox-beta-bidi
--//rb/spec/integration/selenium/webdriver/firefox:service-firefox
--//rb/spec/integration/selenium/webdriver/firefox:service-firefox-beta
--//rb/spec/integration/selenium/webdriver/firefox:service-firefox-beta-bidi
--//rb/spec/integration/selenium/webdriver/firefox:service-firefox-beta-remote
--//rb/spec/integration/selenium/webdriver/firefox:service-firefox-bidi
--//rb/spec/integration/selenium/webdriver/firefox:service-firefox-remote
--//rb/spec/integration/selenium/webdriver/remote:driver-chrome-remote
--//rb/spec/integration/selenium/webdriver/remote:driver-edge-remote
--//rb/spec/integration/selenium/webdriver/remote:driver-firefox-beta-remote
--//rb/spec/integration/selenium/webdriver/remote:driver-firefox-remote
--//rb/spec/integration/selenium/webdriver/remote:element-chrome-remote
--//rb/spec/integration/selenium/webdriver/remote:element-edge-remote
--//rb/spec/integration/selenium/webdriver/remote:element-firefox-beta-remote
--//rb/spec/integration/selenium/webdriver/remote:element-firefox-remote
--//rb/spec/integration/selenium/webdriver:element-chrome
--//rb/spec/integration/selenium/webdriver:element-chrome-bidi
--//rb/spec/integration/selenium/webdriver:element-chrome-remote
--//rb/spec/integration/selenium/webdriver:action_builder-firefox-beta-remote
 -//rb:lint

rb/lib/selenium/webdriver/common/websocket_connection.rb

@@ -94,21 +94,27 @@ def attach_socket_listener
           Thread.current.abort_on_exception = true
           Thread.current.report_on_exception = false
 
-          until socket.eof?
-            incoming_frame << socket.readpartial(1024)
-
-            while (frame = incoming_frame.next)
-              message = process_frame(frame)
-              next unless message['method']
-
-              params = message['params']
-              callbacks[message['method']].each do |callback|
-                @callback_threads.add(callback_thread(params, &callback))
-              end
-            end
+          read_and_process_frames until socket.eof?
+        rescue *CONNECTION_ERRORS => e
+          WebDriver.logger.debug("BiDi socket closed: #{e.class} - #{e.message}", id: :websocket)
+          Thread.exit
+        rescue StandardError => e
+          WebDriver.logger.debug("Unexpected error in BiDi socket thread: #{e.class} - #{e.message}", id: :websocket)
+          Thread.exit
+        end
+      end
+
+      def read_and_process_frames
+        incoming_frame << socket.readpartial(1024)
+
+        while (frame = incoming_frame.next)
+          message = process_frame(frame)
+          next unless message['method']
+
+          params = message['params']
+          callbacks[message['method']].each do |callback|
+            @callback_threads.add(callback_thread(params, &callback))
           end
-        rescue *CONNECTION_ERRORS
-          Thread.stop
         end
       end
 
@@ -142,7 +148,7 @@ def callback_thread(params)
 
           yield params
         rescue Error::WebDriverError, *CONNECTION_ERRORS
-          Thread.stop
+          Thread.exit
         end
       end
 

rb/spec/integration/selenium/webdriver/BUILD.bazel

@@ -42,14 +42,31 @@ rb_library(
             "driver_spec.rb",
             "devtools_spec.rb",
             "element_spec.rb",
+            "network_spec.rb",
         ],
     )
 ]
 
+rb_integration_test(
+    name = "network",
+    srcs = ["network_spec.rb"],
+    tags = [
+        "exclusive-if-local",
+        "bidi-only",
+    ],
+    deps = [
+        "//rb/lib/selenium/devtools",
+        "//rb/lib/selenium/webdriver:bidi",
+    ],
+)
+
 rb_integration_test(
     name = "bidi",
     srcs = ["bidi_spec.rb"],
-    tags = ["exclusive-if-local"],
+    tags = [
+        "exclusive-if-local",
+        "bidi-only",
+    ],
     deps = [
         "//rb/lib/selenium/devtools",
         "//rb/lib/selenium/webdriver:bidi",

rb/spec/integration/selenium/webdriver/action_builder_spec.rb

@@ -321,7 +321,7 @@ module WebDriver
 
       describe '#scroll_by' do
         it 'scrolls by given amount',
-           exclude: {driver: :firefox, reason: 'inconsistent behavior between versions'} do
+           exclude: {browser: :firefox, reason: 'inconsistent behavior between versions'} do
           driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
           footer = driver.find_element(tag_name: 'footer')
           delta_y = footer.rect.y.round

rb/spec/integration/selenium/webdriver/bidi/BUILD.bazel

@@ -4,7 +4,10 @@ load("//rb/spec:tests.bzl", "rb_integration_test")
     rb_integration_test(
         name = file[:-8],
         srcs = [file],
-        tags = ["exclusive-if-local"],
+        tags = [
+            "exclusive-if-local",
+            "bidi-only",
+        ],
         deps = [
             "//rb/lib/selenium/devtools",
             "//rb/lib/selenium/webdriver:bidi",

rb/spec/integration/selenium/webdriver/chrome/BUILD.bazel

@@ -4,7 +4,20 @@ load("//rb/spec:tests.bzl", "rb_integration_test")
     rb_integration_test(
         name = file[:-8],
         srcs = [file],
-        browsers = ["chrome"],  # No need to run in other browsers.
+        browsers = ["chrome"],
+    )
+    for file in glob(
+        ["*_spec.rb"],
+        exclude = ["service_spec.rb"],
     )
-    for file in glob(["*_spec.rb"])
 ]
+
+rb_integration_test(
+    name = "service",
+    srcs = ["service_spec.rb"],
+    browsers = ["chrome"],
+    tags = [
+        "no-grid",
+        "skip-rbe",  # RBE needs internet
+    ],
+)

rb/spec/integration/selenium/webdriver/devtools_spec.rb

@@ -21,8 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe DevTools, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'},
-                                   {browser: %i[chrome edge]}] do
+    describe DevTools, exclusive: {browser: %i[chrome edge]} do
       after { |example| reset_driver!(example: example) }
 
       it 'sends commands' do

rb/spec/integration/selenium/webdriver/edge/BUILD.bazel

@@ -4,7 +4,20 @@ load("//rb/spec:tests.bzl", "rb_integration_test")
     rb_integration_test(
         name = file[:-8],
         srcs = [file],
-        browsers = ["edge"],  # No need to run in other browsers.
+        browsers = ["edge"],
+    )
+    for file in glob(
+        ["*_spec.rb"],
+        exclude = ["service_spec.rb"],
     )
-    for file in glob(["*_spec.rb"])
 ]
+
+rb_integration_test(
+    name = "service",
+    srcs = ["service_spec.rb"],
+    browsers = ["edge"],
+    tags = [
+        "no-grid",
+        "skip-rbe",  # RBE needs internet
+    ],
+)

rb/spec/integration/selenium/webdriver/firefox/BUILD.bazel

@@ -11,5 +11,21 @@ load("//rb/spec:tests.bzl", "rb_integration_test")
         ],
         data = ["//common/extensions"],
     )
-    for file in glob(["*_spec.rb"])
+    for file in glob(
+        ["*_spec.rb"],
+        exclude = ["service_spec.rb"],
+    )
 ]
+
+rb_integration_test(
+    name = "service",
+    srcs = ["service_spec.rb"],
+    browsers = [
+        "firefox",
+        "firefox-beta",
+    ],
+    tags = [
+        "no-grid",
+        "skip-rbe",  # RBE needs internet
+    ],
+)

rb/spec/integration/selenium/webdriver/ie/BUILD.bazel

@@ -0,0 +1,8 @@
+load("//rb/spec:tests.bzl", "rb_integration_test")
+
+rb_integration_test(
+    name = "service",
+    srcs = ["service_spec.rb"],
+    browsers = ["ie"],
+    tags = ["no-grid"],
+)

rb/spec/integration/selenium/webdriver/remote/BUILD.bazel

@@ -4,6 +4,7 @@ load("//rb/spec:tests.bzl", "rb_integration_test")
     rb_integration_test(
         name = file[:-8],
         srcs = [file],
+        tags = ["grid-only"],
     )
     for file in glob(["*_spec.rb"])
 ]

rb/spec/integration/selenium/webdriver/remote/driver_spec.rb

@@ -42,7 +42,9 @@ module Remote
           wait.until { driver.find_element(id: 'upload_label').displayed? }
 
           driver.switch_to.frame('upload_target')
-          wait.until { driver.find_element(xpath: '//body') }
+          wait(ignore: [Error::NoSuchElementError, Error::StaleElementReferenceError]).until do
+            !driver.find_element(xpath: '//body').text.empty?
+          end
 
           body = driver.find_element(xpath: '//body')
           expect(body.text.scan('This is a dummy test file').count).to eq(1)
@@ -83,8 +85,7 @@ module Remote
           end
         end
 
-        it 'errors when not set', {except: {browser: :firefox, reason: 'grid always sets true and firefox returns it'},
-                                   exclude: {browser: :safari, reason: 'grid hangs'}} do
+        it 'errors when not set', {exclude: {browser: :safari, reason: 'grid hangs'}} do
           reset_driver!(enable_downloads: false) do |driver|
             expect {
               driver.downloadable_files

rb/spec/integration/selenium/webdriver/safari/BUILD.bazel

@@ -10,5 +10,18 @@ load("//rb/spec:tests.bzl", "rb_integration_test")
             "safari-preview",
         ],
     )
-    for file in glob(["*_spec.rb"])
+    for file in glob(
+        ["*_spec.rb"],
+        exclude = ["service_spec.rb"],
+    )
 ]
+
+rb_integration_test(
+    name = "service",
+    srcs = ["service_spec.rb"],
+    browsers = [
+        "safari",
+        "safari-preview",
+    ],
+    tags = ["no-grid"],
+)

rb/spec/integration/selenium/webdriver/spec_support/helpers.rb

@@ -97,8 +97,8 @@ def wait_for_new_url(old_url)
           end
         end
 
-        def wait(timeout = 10)
-          Wait.new(timeout: timeout)
+        def wait(timeout = 10, **opts)
+          Wait.new(timeout: timeout, **opts)
         end
 
         def png_size(path)

rb/spec/integration/selenium/webdriver/spec_support/rack_server.rb

@@ -107,7 +107,7 @@ def call(env)
             case env['PATH_INFO']
             when '/upload'
               req = Rack::Request.new(env)
-              body = case req['upload']
+              body = case req.params['upload']
                      when Array
                        req.params['upload'].map { |upload| upload[:tempfile].read }.join("\n")
                      when Hash