-
-
Couldn't load subscription status.
- Fork 58
Live2D fix & improve assets loading progress & improve story reader speed #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR significantly improves the Live2D story reader by enhancing asset loading progress reporting, improving stability through a rewritten PreloadQueue class, optimizing model loading speed, and fixing lipsync issues. The changes also include bumping the Live2D library to the latest upstream version.
- Rewrote PreloadQueue class for better stability and error handling in asset loading
- Fixed lipsync issues for character monologues and multiple character scenarios
- Added comprehensive warning/error reporting during asset loading progress
- Improved model loading speed when characters first appear
Reviewed Changes
Copilot reviewed 25 out of 28 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/storyLoader.ts | Fixed typo changing "identifer" to "identifier" across multiple asset references |
| src/utils/Live2DPlayer/ui_assets.ts | Fixed spelling of "identifier" property throughout UI asset definitions |
| src/utils/Live2DPlayer/load.ts | Major refactor of loading system with new progress handlers and PreloadQueue implementation |
| src/utils/Live2DPlayer/layer/*.ts | Updated references from "identifer" to "identifier" in layer components |
| src/utils/Live2DPlayer/animation/*.ts | Fixed identifier spelling in animation components |
| src/utils/Live2DPlayer/action/*.ts | Updated asset lookup to use new data structure and fixed identifier references |
| src/utils/Live2DPlayer/PreloadQueue.ts | Complete rewrite of PreloadQueue class with improved error handling and concurrency control |
| src/utils/Live2DPlayer/Live2DPlayer.ts | Updated to work with new asset structure |
| src/utils/Live2DPlayer/Live2DController.ts | Major updates to audio handling and asset management |
| src/pages/storyreader-live2d/*.tsx | Updated to use new progress handlers and error reporting |
| package.json | Bumped pixi-live2d-display-mulmotion to version 0.5.0-mm-6 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Can you split the pull request for chibi viewer? |
|
Error in Live2D Viewer: It also happens in Story Reader. Tested in Firefox 141.0.3 on macOS 15.6. There is also bug report in discord complaining Live2D failed to display. |
|
Fixed by add old version of live2d core to public/live2ddependencies. |
|
It has now been clarified why Root Cause: In some ArtMeshes of certain models (e.g., 02saki_cloth001_3.0_f_t09), some components are affected by the combined action of filters and matrix transformations. For these components with Culling enabled, the filter fails to flip them back to their original positions correctly; instead, they remain in the positions before the matrix flip. If during matrix transformation, the code is modified as follows: - array[4] = -matrix.c
- array[5] = -matrix.d
+ array[4] = matrix.c
+ array[5] = matrix.da correct result of vertical flipping will be obtained. Furthermore, setting |
I hope cubism is fine with it, I got a warning cause one repo has it. |
Rebase failed
|
Conflicts need to be cleaned |
|
It can fix #626 |
|
I'll resolve conflicts asap!! |
Description
In live2d story reader:
Related Issue
#616
same fix method with #559
Really don't know why but it works...
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):