AuthLevel decorator
#3439
Merged
AuthLevel decorator
#3439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `SessionInterceptor` doesn't have to make assumptions about the codebase. It doesn't have to know to avoid starting a session for the `session` gql query. It doesn't have to know to avoid starting a session for http requests unless it has the session watermark/(session decorator).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
Anonymous/LoggedIndecorators with an expandedAuthLevel.This new one allows declaring that a session should not even be tried to be resumed, which is needed with our HTTP routes.
So the 3 levels:
sessionless- do not attempt a credential gathering from the requestanonymous- gather credential info & validate token is in db & resume sessionauthenticated- assert that the session is tied to a user aka "logged in"Now
SessionInterceptordoesn't have to make assumptions about the codebase.It doesn't have to know to avoid starting a session for the
sessiongql query.It doesn't have to know to avoid starting a session for http requests unless
it has the session watermark/(session decorator).
This is a smaller PR but distinct with its business logic change, so I wanted to give it its own PR.