Fix inheritance on ID/ResourceName types #3434
Conversation
I think this must've changed when we removed the static Props declarations. Previously comparing static types worked, probably because of the static Prop list. Now comparing instance types appears to work, which seems more correct anyway.
CarsonF
force-pushed
the
bugfix/id-types-inheritance
branch
from
8e9c1e8 to
dd5eb22
Compare
📝 WalkthroughWalkthroughThe changes introduce stricter and more explicit typing for type discriminator properties such as Changes
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms (11)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| e.insert(e.SystemAgent, { name, roles }), | ||
| ); | ||
| const query = e.select(upserted, (agent) => ({ | ||
| __typename: e.str('SystemAgent' as const), |
There was a problem hiding this comment.
I had to rewrite this query to use the query builder, because EdgeQL doesn't understand string literals, so even though I could write the constant "SystemAgent" it would still be widened to a TS string, by the EdgeQL server.
I think this must've changed when we removed the static
Propsdeclarations.Previously comparing static types worked, probably because of the static
Propslist.Now comparing instance types appears to work, which seems more correct anyway.
However, this uses duck typing / shape matching, not actual inheritance.
So we had a problem with
Pinnable&Actor, both of which only require anidprop.I "fixed", worked around this by declaring the
__typenamestring literals forActor/User/SystemAgent.This is more feasible than enumerating the concrete types of
Pinnable& doing the same on them.It's working now, but not the most stable situation to be in. Will continue pondering other ways to address this.