Swap AsyncResource with ALS.snapshot #3433
Conversation
📝 WalkthroughWalkthroughThe code replaces the use of Changes
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/core/graphql/driver.ts (2)
108-112: Use the official snapshot type for better type-safetyManually spelling out the function type
<R>(fn: () => R) => Ris (a) slightly narrower than the real signature returned byAsyncLocalStorage.snapshot()(which supports forwarding arguments), and (b) easy to get out-of-sync with future Node versions.
You can make the intent crystal-clear and stay future-proof by deriving the type instead:-const asyncContextBySocket = new WeakMap< - WebSocket, - <R>(fn: () => R) => R ->(); +type Snapshot = ReturnType<typeof AsyncLocalStorage.snapshot>; +const asyncContextBySocket = new WeakMap<WebSocket, Snapshot>();
179-181: Clean up map entry eagerly to minimise memory retentionUsing
WeakMapprevents leaking sockets, but the snapshot closure can keep significant state alive until the socket itself becomes unreachable/GC-ed.
Releasing the reference oncloseremoves that pressure sooner and signals intent:asyncContextBySocket.set(socket, AsyncLocalStorage.snapshot()); socket.on('close', () => { asyncContextBySocket.delete(socket); });(The additional listener is negligible because each socket already installs several.)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/core/graphql/driver.ts(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: E2E Tests (neo4j 6/6)
- GitHub Check: E2E Tests (neo4j 5/6)
- GitHub Check: E2E Tests (neo4j 4/6)
- GitHub Check: E2E Tests (neo4j 3/6)
- GitHub Check: E2E Tests (neo4j 2/6)
- GitHub Check: Generate (head)
- GitHub Check: E2E Tests (neo4j 1/6)
- GitHub Check: lint
- GitHub Check: Generate (base)
- GitHub Check: Unit
- GitHub Check: Clean
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
src/core/graphql/driver.ts (1)
16-16: Verify minimum runtime & TypeScript targets
AsyncLocalStorage.snapshot()is available starting Node 22 and its types are only present in@types/node@22(or the built-in lib for that version).
Please ensure:
package.json→"engines": { "node": ">=22.0.0" }- The project’s
tsconfig.jsonpoints to the correct lib ("lib": ["es2022"]or higher) or installs the matching@types/node.Otherwise CI/type-checks will fail even though the code is correct at runtime.
This stabilized in Node 22, and seems to be recommended for the simple situations like this case here.