Fix PnP named range crashes #3430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of the PnP has named ranges like ``` [1]SheetName!A1 ``` These brackets typically refer to the file paths of external workbooks. But when Excel has multiple workbooks open, it can assign a temporary index here as well. These can be safely ignored.
This comment was marked as off-topic.
This comment was marked as off-topic.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The errors we throw are probably 80% going to be our problem, not users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an excel file is saved while there are multiple open, it can add internal index workbook references in named ranges (probably all formulas?)
Like:
This can be safely parsed to mean
A1onSheetName.The index is an internal thing that I don't think is even presented to users in Excel, but it does leak through in our navigation tools.
Now we ignore those optional
[N]prefixes.We also just ignore any named ranges that correspond to nonexistent sheets now.
This will prevent an all out extract crash just from a named range that we do not care about.