Workaround regression in Neo4j 5.26.x with optional match usage in project sensitivity calc #3418
Conversation
…oject sensitivity calc This isn't the first time we've seen problems with optional match clauses. Instead of trying to let neo4j maintain cardinality a carry a null value, now will require match in a subquery and then collect the result to maintain cardinality. optional match -> subquery, match, collect
📝 WalkthroughWalkthroughThe change updates the internal logic of the Changes
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/core/database/query/match-project-based-props.ts (1)
131-146: Solid approach to address the Neo4j 5.26.x regression.This implementation correctly addresses the regression in Neo4j 5.26.x by replacing the optional match with a subquery. The collection of sensitivities using
collect()ensures that cardinality is maintained, even when no sensitivities are matched, allowing the query to continue execution as expected.The subquery approach effectively encapsulates the sensitivity matching and ordering logic while maintaining the same functional behavior.
Consider extracting the default sensitivity value "High" (which appears at line 146 and line 155) into a constant at the module level to improve maintainability.
+ const DEFAULT_SENSITIVITY: Sensitivity = "High"; // ... - .return(coalesce('sensitivities[0]', '"High"').as(output)) + .return(coalesce('sensitivities[0]', `"${DEFAULT_SENSITIVITY}"`).as(output)) // ... - .return<Record<Output, Sensitivity>>(`"High" as ${output}`), + .return<Record<Output, Sensitivity>>(`"${DEFAULT_SENSITIVITY}" as ${output}`),
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/core/database/query/match-project-based-props.ts(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/core/database/query/match-project-based-props.ts (2)
src/core/database/query/matching.ts (1)
ACTIVE(27-27)src/core/database/query/cypher-functions.ts (2)
collect(29-29)coalesce(47-47)
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: E2E Tests (neo4j 6/6)
- GitHub Check: E2E Tests (neo4j 5/6)
- GitHub Check: E2E Tests (neo4j 4/6)
- GitHub Check: E2E Tests (neo4j 3/6)
- GitHub Check: E2E Tests (neo4j 2/6)
- GitHub Check: Generate (head)
- GitHub Check: Unit
- GitHub Check: E2E Tests (neo4j 1/6)
- GitHub Check: Generate (base)
- GitHub Check: Clean
- GitHub Check: lint
- GitHub Check: Analyze (javascript)
This isn't the first time we've seen problems with optional match clauses. Instead of trying to let neo4j maintain cardinality a carry a null value, now will require match in a subquery and then collect the result to maintain cardinality.
optional match -> subquery, match, collect