Skip to content

Add PartnerFilters.startDate #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Conversation

rdonigian
Copy link
Contributor

Add the startDate field to the Partner filters

@rdonigian rdonigian requested a review from CarsonF as a code owner April 23, 2025 20:32
Copy link

coderabbitai bot commented Apr 23, 2025

📝 Walkthrough

Walkthrough

The changes introduce a new optional startDate filter for partner-related queries. In the data transfer object, a startDate field of type DateFilter is added to the PartnerFilters input, complete with appropriate GraphQL, validation, and transformation decorators. Correspondingly, the repository's filter definition is updated to include a startDate property using a dateTimeProp filter, enabling the backend to process this new filter criterion.

Changes

File(s) Change Summary
src/components/partner/dto/list-partner.dto.ts Added optional startDate field of type DateFilter to PartnerFilters with decorators for GraphQL, validation, and transformation.
src/components/partner/partner.repository.ts Added startDate as a new filter property in the partnerFilters constant using dateTimeProp().

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e626ee1 and 0fd18db.

📒 Files selected for processing (2)
  • src/components/partner/dto/list-partner.dto.ts (2 hunks)
  • src/components/partner/partner.repository.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (12)
  • GitHub Check: E2E Tests (neo4j 6/6)
  • GitHub Check: E2E Tests (neo4j 5/6)
  • GitHub Check: E2E Tests (neo4j 4/6)
  • GitHub Check: E2E Tests (neo4j 3/6)
  • GitHub Check: E2E Tests (neo4j 2/6)
  • GitHub Check: Unit
  • GitHub Check: Generate (head)
  • GitHub Check: E2E Tests (neo4j 1/6)
  • GitHub Check: Clean
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Generate (base)
  • GitHub Check: lint
🔇 Additional comments (3)
src/components/partner/partner.repository.ts (1)

345-345: Looks good - startDate filter properly added

The addition of the startDate filter using filter.dateTimeProp() is correct and consistent with how other date filters are implemented in the repository.

src/components/partner/dto/list-partner.dto.ts (2)

2-3: Necessary imports correctly added

The imports for Type, ValidateNested, and DateFilter are correctly added to support the new startDate filter field.

Also applies to: 5-5


46-51: startDate filter field correctly implemented

The startDate field is properly decorated with the necessary GraphQL, transformation, and validation decorators. The implementation follows the pattern established by other filter fields in this class.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

🗞 GraphQL Summary

View schema changes
@@ -3705,8 +3705,9 @@
   organization: OrganizationFilters
 
   """Only partners that are pinned/unpinned by the requesting user"""
   pinned: Boolean
+  startDate: DateFilter
   types: [PartnerType!]
 }
 
 input PartnerListInput {

⚠️ Dangerous Changes

  • An optional field startDate on input type PartnerFilters was added.

@CarsonF CarsonF changed the title Add startDate to Partner filters Add PartnerFilters.startDate Apr 23, 2025
@CarsonF CarsonF merged commit f8f6131 into develop Apr 23, 2025
17 checks passed
@CarsonF CarsonF deleted the add-startDate-filter-partners branch April 23, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants