Remove legacy APIs & transitional code for project workflow #3267
Conversation
CarsonF
added
the
💥 Breaking Change
🗞 GraphQL SummaryView schema changes@@ -896,9 +896,8 @@
primaryLocationId: ID
"""Defaults to High, only available on internship projects"""
sensitivity: Sensitivity
- step: ProjectStep
tags: [String!] = []
type: ProjectType!
}
@@ -5045,30 +5044,8 @@
"""@order 26"""
Terminated
}
-"""
-A transition for the project workflow.
-
-This is not a normalized entity.
-A transition represented by its `key` can have different field values
-based on the workflow's state.
-"""
-type ProjectStepTransition {
- disabled: Boolean!
- disabledReason: String
-
- """
- An local identifier for this transition.
- It cannot be used to globally identify a transition.
- It is passed to the transition mutation.
- """
- key: ID!
- label: String!
- to: ProjectStep!
- type: TransitionType!
-}
-
enum ProjectType {
"""@order 2"""
Internship
@@ -5103,12 +5080,34 @@
notes: SecuredRichTextNullable!
to: ProjectStep!
"""The transition taken, null if workflow was bypassed"""
- transition: ProjectStepTransition
+ transition: ProjectWorkflowTransition
who: SecuredActor!
}
+"""
+A transition for the project workflow.
+
+This is not a normalized entity.
+A transition represented by its `key` can have different field values
+based on the workflow's state.
+"""
+type ProjectWorkflowTransition {
+ disabled: Boolean!
+ disabledReason: String
+
+ """
+ An local identifier for this transition.
+ It cannot be used to globally identify a transition.
+ It is passed to the transition mutation.
+ """
+ key: ID!
+ label: String!
+ to: ProjectStep!
+ type: TransitionType!
+}
+
type Prompt {
"""Whether the requesting user can delete this resource"""
canDelete: Boolean!
createdAt: DateTime!
@@ -6663,9 +6662,9 @@
canEdit: Boolean!
canRead: Boolean!
"""The transitions currently available to execute for this project"""
- transitions: [ProjectStepTransition!]!
+ transitions: [ProjectWorkflowTransition!]!
value: ProjectStep
}
"""
@@ -7789,9 +7788,8 @@
primaryLocationId: ID
"""Update only available to internship projects"""
sensitivity: Sensitivity
- step: ProjectStep
tags: [String!]
}
input UpdateProjectChangeRequest {
🚨 Breaking Changes
|
CarsonF
force-pushed
the
drop-old-project-step-mutation
branch
2 times, most recently
from
10478a3 to
662c4cf
Compare
CarsonF
changed the base branch from
develop
to
tests/new-project-workflow-kinda
CarsonF
force-pushed
the
drop-old-project-step-mutation
branch
from
662c4cf to
960c901
Compare
CarsonF
force-pushed
the
drop-old-project-step-mutation
branch
from
960c901 to
2c50e17
Compare
📝 WalkthroughWalkthroughThis change removes the deprecated and legacy handling of the Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
💤 Files with no reviewable changes (2)
🧰 Additional context used🧬 Code Graph Analysis (1)src/components/project/workflow/dto/workflow-transition.dto.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms (12)
🔇 Additional comments (9)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
CarsonF
force-pushed
the
drop-old-project-step-mutation
branch
from
2c50e17 to
c89326a
Compare
|
@bryanjnelson thoughts here? We aren't using this in UI, DOMO, or multiplication sync? |
?
Originally we said we thought we were still going to be using this path from the multiplication sync. I guess we landed on not doing that? 🤔 |
Right we aren't doing that. We decided to the proper thing there and look at the available transitions. |
UI is migrated to new paths & doesn't reference these type names.