-
Notifications
You must be signed in to change notification settings - Fork 6
WIP #3223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
WIP #3223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that a single transition can have multiple states based on other things (like project state).
This opens the door for `from` field & generic abstraction
Closing until we are closer to being done |
🗞 GraphQL SummaryView schema changes@@ -1604,8 +1604,28 @@
"""
transition: ID
}
+input ExecuteProjectTransitionInput {
+ """Any additional user notes related to this transition"""
+ notes: RichText
+
+ """The project ID to transition"""
+ project: ID!
+
+ """
+ Bypass the workflow, and go straight to this step.
+ `transition` is not required and ignored when using this.
+ """
+ step: ProjectStep
+
+ """
+ The transition `key` to execute.
+ This is required unless specifying bypassing the workflow with a `step` input.
+ """
+ transition: ID
+}
+
"""
First scripture that has been created but managed _outside_ of CORD. `hasFirst` will always be true.
"""
type ExternalFirstScripture implements FirstScripture {
@@ -2229,8 +2249,9 @@
"""The project members"""
team(input: ProjectMemberListInput = {count: 25, filter: {}, order: ASC, page: 1, sort: "createdAt"}): SecuredProjectMemberList!
type: ProjectType!
+ workflowEvents: [ProjectWorkflowEvent!]!
}
type InternshipProjectListOutput implements PaginatedList {
"""Whether the next page exists"""
@@ -2724,8 +2745,9 @@
"""The project members"""
team(input: ProjectMemberListInput = {count: 25, filter: {}, order: ASC, page: 1, sort: "createdAt"}): SecuredProjectMemberList!
type: ProjectType!
+ workflowEvents: [ProjectWorkflowEvent!]!
}
input MoveFileInput {
"""The file or directory's ID"""
@@ -2840,8 +2862,9 @@
"""The project members"""
team(input: ProjectMemberListInput = {count: 25, filter: {}, order: ASC, page: 1, sort: "createdAt"}): SecuredProjectMemberList!
type: ProjectType!
+ workflowEvents: [ProjectWorkflowEvent!]!
}
type Mutation {
"""Add a location to a language"""
@@ -3094,8 +3117,9 @@
"""
pinned: Boolean
): Boolean!
transitionProgressReport(input: ExecuteProgressReportTransitionInput!): ProgressReport!
+ transitionProject(input: ExecuteProjectTransitionInput!): Project!
"""Update a budget"""
updateBudget(input: UpdateBudgetInput!): UpdateBudgetOutput!
@@ -4416,8 +4440,9 @@
"""The project members"""
team(input: ProjectMemberListInput = {count: 25, filter: {}, order: ASC, page: 1, sort: "createdAt"}): SecuredProjectMemberList!
type: ProjectType!
+ workflowEvents: [ProjectWorkflowEvent!]!
}
type ProjectChangeRequest implements Changeset & Resource {
"""Whether the changes have been applied to live data"""
@@ -4628,11 +4653,25 @@
Suspended
Terminated
}
+"""
+A transition for the project workflow.
+
+This is not a normalized entity.
+A transition represented by its `key` can have different field values
+based on the project's state.
+"""
type ProjectStepTransition {
disabled: Boolean!
disabledReason: String
+
+ """
+ An local identifier for this transition.
+ It cannot be used to globally identify a transition.
+ It is passed to `transitionProject`.
+ """
+ key: ID!
label: String!
to: ProjectStep!
type: TransitionType!
}
@@ -4665,8 +4704,19 @@
projectTypes: [ProjectType!]!
user: ID!
}
+type ProjectWorkflowEvent {
+ at: DateTime!
+ id: ID!
+ notes: SecuredRichTextNullable!
+ to: ProjectStep!
+
+ """The transition taken, null if workflow was bypassed"""
+ transition: ProjectStepTransition
+ who: SecuredUser!
+}
+
type Prompt {
"""Whether the requesting user can delete this resource"""
canDelete: Boolean!
createdAt: DateTime!
@@ -6160,9 +6210,9 @@
"""
type SecuredProjectStep implements Secured {
"""
Is the current user allowed to bypass transitions entirely
- and change the step to any other step?
+ and change the status to any other step?
"""
canBypassTransitions: Boolean!
canEdit: Boolean!
canRead: Boolean!
@@ -6645,8 +6695,9 @@
"""The project members"""
team(input: ProjectMemberListInput = {count: 25, filter: {}, order: ASC, page: 1, sort: "createdAt"}): SecuredProjectMemberList!
type: ProjectType!
+ workflowEvents: [ProjectWorkflowEvent!]!
}
type TranslationProjectListOutput implements PaginatedList {
"""Whether the next page exists"""
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monday