Skip to content

EdgeDB - Partner and Organization Queries #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 7, 2024

Conversation

brentkulwicki
Copy link
Contributor

@brentkulwicki brentkulwicki commented Mar 5, 2024

Monday task

Reason for this PR

Migrate Partner and Organization Queries to edgedb

Ready for review checklist

  • Change the task url above to the actual Monday task
  • [N/A] Add/update tests if needed
  • Add reviewers to this PR

@brentkulwicki brentkulwicki force-pushed the edgedb-queries-organization-and-partner branch from fc2836a to d77b578 Compare March 13, 2024 13:52
@brentkulwicki brentkulwicki force-pushed the edgedb-queries-organization-and-partner branch from 0674218 to bc274ab Compare March 27, 2024 16:44
@brentkulwicki brentkulwicki marked this pull request as ready for review March 27, 2024 17:41
@brentkulwicki brentkulwicki requested a review from CarsonF as a code owner March 27, 2024 17:41
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to rebase this and continue here @brentkulwicki?
The yarn changes should be reverted.

There should be other examples of edgedb repos you can follow now.

@brentkulwicki
Copy link
Contributor Author

Want to rebase this and continue here @brentkulwicki? The yarn changes should be reverted.

There should be other examples of edgedb repos you can follow now.

Any notes on here? Maybe this will be fine now that I am on a new machine, but I felt like this one was done (outside of all the errors I had that I thought were the issues locally)

@brentkulwicki brentkulwicki force-pushed the edgedb-queries-organization-and-partner branch from f6863a1 to 503de3e Compare April 19, 2024 14:14
@brentkulwicki brentkulwicki force-pushed the edgedb-queries-organization-and-partner branch from 503de3e to 5afced1 Compare April 26, 2024 16:34
@brentkulwicki brentkulwicki force-pushed the edgedb-queries-organization-and-partner branch from 1b8c711 to 7f17053 Compare May 2, 2024 16:02
Copy link

github-actions bot commented May 3, 2024

🗞 GraphQL Summary

View schema changes
@@ -3240,9 +3240,9 @@
 }
 
 type Organization implements Resource {
   acronym: SecuredStringNullable!
-  address: SecuredString!
+  address: SecuredStringNullable!
   avatarLetters: String
 
   """Whether the requesting user can delete this resource"""
   canDelete: Boolean!
@@ -3412,9 +3412,9 @@
 }
 
 type Partner implements Pinnable & Postable & Resource {
   active: SecuredBoolean!
-  address: SecuredString!
+  address: SecuredStringNullable!
 
   """Whether the requesting user can delete this resource"""
   canDelete: Boolean!
   countries: SecuredLocations!
@@ -3434,9 +3434,9 @@
   organization: SecuredOrganization!
 
   """Does the requesting user have this pinned?"""
   pinned: Boolean!
-  pmcEntityCode: SecuredString!
+  pmcEntityCode: SecuredStringNullable!
   pointOfContact: SecuredUser!
 
   """List of posts belonging to the parent node."""
   posts(input: PostListInput = {count: 25, order: DESC, page: 1, sort: "createdAt"}): SecuredPostList!

🚨 Breaking Changes

  • Organization.address changed type from SecuredString! to SecuredStringNullable!.
  • Partner.address changed type from SecuredString! to SecuredStringNullable!.
  • Partner.pmcEntityCode changed type from SecuredString! to SecuredStringNullable!.

@brentkulwicki brentkulwicki added the 💥 Breaking Change Introduces changes that are not backward compatible and may require modifications in other systems label May 3, 2024
@brentkulwicki brentkulwicki requested a review from CarsonF May 3, 2024 16:06
@brentkulwicki
Copy link
Contributor Author

Still some fixes to make here 🤔

@brentkulwicki brentkulwicki force-pushed the edgedb-queries-organization-and-partner branch from 922f2ba to ada4443 Compare May 6, 2024 20:08
@brentkulwicki brentkulwicki requested a review from CarsonF May 7, 2024 18:12
CarsonF and others added 8 commits May 7, 2024 17:01
@CarsonF CarsonF force-pushed the edgedb-queries-organization-and-partner branch from 4380483 to 51c93e6 Compare May 7, 2024 22:04
@CarsonF CarsonF enabled auto-merge May 7, 2024 22:08
@CarsonF CarsonF merged commit d469ca6 into develop May 7, 2024
21 checks passed
@CarsonF CarsonF deleted the edgedb-queries-organization-and-partner branch May 7, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 Breaking Change Introduces changes that are not backward compatible and may require modifications in other systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants