Skip to content

feat!: drop async_trait usage #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2024
Merged

feat!: drop async_trait usage #7

merged 4 commits into from
Mar 19, 2024

Conversation

SeaDve
Copy link
Owner

@SeaDve SeaDve commented Jan 27, 2024 •
edited
Loading

Regressions:

  • Lost specialized documentation on local variants
  • Lost subtraits on Send versions

@SeaDve SeaDve mentioned this pull request Jan 27, 2024
Closed
@SeaDve
Copy link
Owner Author

SeaDve commented Feb 7, 2024

Regressions can be fixed in the future with rust-lang/impl-trait-utils#27.

@SeaDve SeaDve force-pushed the afit branch 2 times, most recently from 11e3b18 to 555e979 Compare February 14, 2024 14:32
@SeaDve
Copy link
Owner Author

SeaDve commented Feb 14, 2024

Will merge once trait_variant crate makes a release.

@SeaDve SeaDve merged commit 85b3442 into main Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SeaDve