Skip to content

Pre/beta #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2025
Merged

Pre/beta #923

merged 2 commits into from
Feb 15, 2025

Conversation

VinciGit00
Copy link
Collaborator

No description provided.

VinciGit00 and others added 2 commits February 13, 2025 12:37
## [1.38.1-beta.1](v1.38.0...v1.38.1-beta.1) (2025-02-13)

### Bug Fixes

* filter links ([04b9197](04b9197))

### Test

* Add coverage improvement test for tests/test_scrape_do.py ([4ce6d1b](4ce6d1b))
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 13, 2025
Copy link
Contributor

codebeaver-ai bot commented Feb 13, 2025

I tried to generate new tests but there might be some issues in your codebase that I couldn't fix.

🔄 Could not generate any new tests.
🐛 Found 1 bug
🛠️ 0/2 tests passed

🐛 Bug Detection

Potential issues found in the following files:

  • scrapegraphai/graphs/search_link_graph.py

The error is caused by the code that is being tested; specifically, the AbstractGraph’s init method accesses config.get("llm").get("temperature") without first ensuring that config contains a non-None value for the "llm" key. In the test, the config dictionary does not include an "llm" key, so config.get("llm") returns None and attempting to call get("temperature") on None leads to the AttributeError.

🛠️ Test Results

0/2 tests passed ⚠️

tests/graphs/scrape_graph_test.py

View error
ImportError while importing test module '/app/temp_workspace/tests/graphs/scrape_graph_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/graphs/scrape_graph_test.py:10: in <module>
    from scrapegraphai.graphs import ScrapeGraph
E   ImportError: cannot import name 'ScrapeGraph' from 'scrapegraphai.graphs' (/app/temp_workspace/scrapegraphai/graphs/__init__.py)

tests/graphs/scrape_graph_test.py

tests/graphs/xml_scraper_openai_test.py

View error
ImportError while importing test module '/app/temp_workspace/tests/graphs/xml_scraper_openai_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/graphs/xml_scraper_openai_test.py:11: in <module>
    from scrapegraphai.utils import convert_to_csv, convert_to_json, prettify_exec_info
E   ImportError: cannot import name 'convert_to_csv' from 'scrapegraphai.utils' (/app/temp_workspace/scrapegraphai/utils/__init__.py)

tests/graphs/xml_scraper_openai_test.py


Settings | Logs | CodeBeaver

@VinciGit00 VinciGit00 merged commit 5b67e97 into main Feb 15, 2025
5 checks passed
Copy link

🎉 This PR is included in version 1.38.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.39.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @dev released on @stable size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants