Skip to content

Allow to customize scrape.do proxy/api endpoints #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Verz1Lka
Copy link
Contributor

@Verz1Lka Verz1Lka commented Feb 1, 2025

No description provided.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Feb 1, 2025
Copy link
Contributor

codebeaver-ai bot commented Feb 1, 2025

CodeBeaver PR Summary

I opened a Pull Request with the following:

🔄 1 test added.
🐛 No bugs detected in your changes
🛠️ 0/2 tests passed

🔄 Test Updates

I've added 1 tests. They all pass ☑️
New Tests:

  • tests/test_scrape_do.py

No existing tests required updates.

🐛 Bug Detection

No bugs detected in your changes. Good job!

🛠️ Test Results

0/2 tests passed ⚠️

tests/graphs/scrape_graph_test.py

View error
ImportError while importing test module '/app/temp_workspace/tests/graphs/scrape_graph_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/graphs/scrape_graph_test.py:10: in <module>
    from scrapegraphai.graphs import ScrapeGraph
E   ImportError: cannot import name 'ScrapeGraph' from 'scrapegraphai.graphs' (/app/temp_workspace/scrapegraphai/graphs/__init__.py)

tests/graphs/scrape_graph_test.py

tests/graphs/xml_scraper_openai_test.py

View error
ImportError while importing test module '/app/temp_workspace/tests/graphs/xml_scraper_openai_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/graphs/xml_scraper_openai_test.py:10: in <module>
    from scrapegraphai.utils import convert_to_csv, convert_to_json, prettify_exec_info
E   ImportError: cannot import name 'convert_to_csv' from 'scrapegraphai.utils' (/app/temp_workspace/scrapegraphai/utils/__init__.py)

tests/graphs/xml_scraper_openai_test.py

☂️ Coverage Improvements

Coverage improvements by file:

  • tests/test_scrape_do.py

    New coverage: 82.35%
    Improvement: +82.35%

🎨 Final Touches

  • I ran the hooks included in the pre-commit config.

Settings | Logs | CodeBeaver

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 6, 2025
@VinciGit00 VinciGit00 merged commit 1b142c9 into ScrapeGraphAI:main Feb 6, 2025
4 checks passed
Copy link

github-actions bot commented Feb 9, 2025

🎉 This PR is included in version 1.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer released on @stable size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants