543 script creator graph only use first chunk #619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial fix for #543 when using ScriptCreatorGraph. Because ParseNode provides multiple chunks when scraping long HTML pages, I have updated ScriptCreatorGraph to only use the first chunk, on the basis the structure of the remaining page is likely similar, therefore the generated script will work.
This seems to be working fine when using this scraper script:
The code above results in the following script being generated:
The generated script seems to work fine. I think it's worth going with this solution for now, as I suspect it will work fine most of the time, and when I have a bit of spare time I will look at the idea of creating a script for each chunk and asking the LLM to merge the scripts.