Generate answer parallel #480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big update
## [1.10.0](v1.9.2...v1.10.0) (2024-07-20) ### Features * add gpt4o omni ([431edb7](431edb7)) * add searchngx integration ([5c92186](5c92186)) * refactoring_to_md function ([602dd00](602dd00)) ### Bug Fixes * add gpt o mini for azure ([77777c8](77777c8)) * parse_node ([07f1e23](07f1e23)) * search link node ([cf3ab55](cf3ab55)) ### chore * correct search engine name ([7ba2f6a](7ba2f6a)) * remove unused import ([fd1b7cb](fd1b7cb)) * **ci:** upgrade lockfiles ([c7b05a4](c7b05a4)) * upgrade tiktoken ([7314bc3](7314bc3)) ### Docs * **gpt-4o-mini:** added new gpt, fixed chromium lazy loading, ([99dc849](99dc849)) ### CI * **release:** 1.10.0-beta.1 [skip ci] ([8f619de](8f619de)) * **release:** 1.10.0-beta.2 [skip ci] ([aa7d4f0](aa7d4f0)) * **release:** 1.10.0-beta.3 [skip ci] ([bf0a2f3](bf0a2f3)) * **release:** 1.10.0-beta.4 [skip ci] ([a91807a](a91807a)) * **release:** 1.10.0-beta.5 [skip ci] ([0d5f925](0d5f925)) * **release:** 1.9.0-beta.3 [skip ci] ([d3e63d9](d3e63d9)) * **release:** 1.9.0-beta.4 [skip ci] ([2fa04b5](2fa04b5)) * **release:** 1.9.0-beta.5 [skip ci] ([bb62439](bb62439)) * **release:** 1.9.0-beta.6 [skip ci] ([54a69de](54a69de))
## [1.10.1](v1.10.0...v1.10.1) (2024-07-21) ### Bug Fixes * abstract_graph moel token bug ([ce6be37](ce6be37))
## [1.10.2](v1.10.1...v1.10.2) (2024-07-21) ### Bug Fixes * telemetry version ([b0418b6](b0418b6))
DiTo97
requested changes
Jul 22, 2024
|
|
||
| # Use tqdm to add progress bar | ||
| for i, chunk in enumerate(tqdm(doc, desc="Processing chunks", disable=not self.verbose)): | ||
| if len(doc) == 1: | ||
| # No batching needed for single chunk |
There was a problem hiding this comment.
why checking the document length inside the for-loop and not outside of it?
rather, the for-loop should be in place only if the document has multiple chunks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.