Issue 327 Resolved #372
Merged
Issue 327 Resolved #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 1.7.0-beta.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve the issue, we need to ensure that the 'headless' flag is correctly passed and utilized in the FetchNode configuration. Additionally, adding logging statements will help verify that the HTML content is being fetched correctly.
To resolve the issue, we need to add logging to capture the HTML content before parsing, add a fallback mechanism to handle cases where the body tag is not found, and modify the ValueError message to include the HTML content for debugging purposes.
To resolve the issue, we need to add logging to verify the HTML content fetched, ensure the
headlessflag is correctly passed toChromiumLoader, add error handling to check if the HTML content is empty before passing it tocleanup_html, and modify thecleanup_htmlfunction call to handle cases where the HTML content might be empty.