Skip to content

Conversation

@examosa
Copy link
Contributor

@examosa examosa commented Oct 31, 2025

Resolves #16512

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Added Windows package configuration for Txr programming language, enabling automated version detection and multi-architecture support with streamlined updates.

@github-actions
Copy link
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

txr

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@coderabbitai
Copy link

coderabbitai bot commented Oct 31, 2025

Walkthrough

A new JSON manifest file for the Txr programming language package is introduced, containing metadata, architecture-specific download URLs with SHA256 hashes, installation configuration, version extraction patterns, and automated update parameterization to enable live-updates and binary installation on Windows.

Changes

Cohort / File(s) Summary
New Txr Package Manifest
bucket/txr.json
Adds package manifest with version 302, supporting 64-bit and 32-bit architectures, including download URLs, SHA256 verification hashes, binary installation paths, version checking via regex pattern, and autoupdate configuration with parameterized download links

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify JSON syntax validity and proper structure
  • Validate SHA256 hashes match the referenced download URLs
  • Confirm version extraction regex pattern correctly parses version numbers from the specified checkver URL
  • Cross-check metadata accuracy (homepage, license, description) against official sources

Poem

🐰 A manifest appears, so neat and fine,
For Txr the language, now does shine!
With hashes, URLs, and versions in place,
Updates will hop along at a rapid pace! 🎉

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "txr: Add version 302" follows the conventional format specified in the repository's contributing guidelines (<manifest-name[@version]>: <summary>). The title is clear, concise, and directly describes the primary change: adding a new manifest for version 302 of the txr programming language package. It provides enough context for someone scanning the repository history to understand the main purpose of the change without being vague or misleading.
Linked Issues Check ✅ Passed The pull request successfully addresses the objectives in linked issue #16512. The change adds a new manifest file for the txr programming language with version 302, meeting the core request to add this package. The manifest includes essential configuration elements: download URLs pointing to the official source (https://www.kylheku.com/txr-downloads/), architecture-specific binaries, version checking and auto-update mechanisms, and proper metadata (homepage, license, description). These elements align with the stated requirements for a fairly standard install using version-specific download URLs without elaborate scripts.
Out of Scope Changes Check ✅ Passed The pull request contains only in-scope changes directly aligned with the linked issue #16512 objectives. A single new file, bucket/txr.json, is added to create a manifest for the txr programming language package. No extraneous modifications, refactoring, or unrelated changes are present. The change scope is focused and appropriate for fulfilling the package addition request without introducing modifications beyond the stated objectives.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba8b272 and 9dc0410.

📒 Files selected for processing (1)
  • bucket/txr.json (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (4)
bucket/txr.json (4)

1-15: Manifest structure and URLs look good.

The metadata, version, and architecture-specific URLs with hashes follow correct Scoop conventions. The 7z extraction fragment is appropriately specified.


16-20: Extract directory and binary paths are correct.

The extraction directory and bin entries follow Scoop conventions. Two executables (txr.exe and txr-win.exe) suggest both CLI and GUI variants are available.


21-24: Version checking pattern is standard but fragile.

The checkver configuration scrapes version numbers from a directory listing. While this is common, it depends on the HTML structure remaining stable. Consider monitoring if version detection fails in future updates.


25-37: No issues identified with autoupdate configuration.

The CHECKSUMS file exists at the correct location and contains valid SHA256 hashes for both Win32 and Win64 executables. The $baseurl variable correctly resolves to https://www.kylheku.com/txr-downloads/txr-302/, making the hash URL properly formed. The hashes in the manifest match the CHECKSUMS file, and the file format is parseable by Scoop.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@examosa
Copy link
Contributor Author

examosa commented Nov 3, 2025

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

All changes look good.

Wait for review from human collaborators.

txr

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: TXR Language

1 participant