use [sources] #2699
Merged
use [sources] #2699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
May 5, 2025
|
Looking at https://pkgdocs.julialang.org/v1.10/toml-files/ and https://pkgdocs.julialang.org/v1.11/toml-files/, it seems like the |
|
that is correct. on 1.10 and under, this change won't do anything (but everything will still work) |
|
Thanks! Just wanted to confirm this. |
|
@avik-pal what did you do to make this work for CI on NonlinearSolve? |
|
it pretty much just worked 😅. NonlinearSolve does have a per subpackage CI workflow. Can you try and change https://github.com/oscardssmith/OrdinaryDiffEq.jl/blob/7a35128936dd2fbbf759db93545cf87b3fc0a867/.github/workflows/CI.yml#L84 to run only on 1.10? |
|
lets try it... |
|
that seems to work. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the OrdinaryDiffEq followup to SciML/NonlinearSolve.jl#571.